Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use C++11 alias templates instead of macro-defined types to implement specialized holder wrappers. #35863

Merged
merged 3 commits into from
May 7, 2020

Conversation

jkoritzinsky
Copy link
Member

Use C++11 alias templates instead of macro-defined types to implement specialized holder wrappers.

@jkotas
Copy link
Member

jkotas commented May 6, 2020

/azp run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@jkotas
Copy link
Member

jkotas commented May 6, 2020

/azp run runtime

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once we convince CI to run

@jkotas jkotas added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label May 6, 2020
@jkoritzinsky
Copy link
Member Author

I've successfully coaxed CI to run. I'll remove the 'no merge' label and merge on green CI.

@jkoritzinsky jkoritzinsky added auto-merge and removed NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) labels May 6, 2020
@ghost
Copy link

ghost commented May 6, 2020

Hello @jkoritzinsky!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@jkoritzinsky
Copy link
Member Author

Test failure is #35877, fixed by #35904. I'll merge this in.

@jkoritzinsky jkoritzinsky merged commit 5199a8c into dotnet:master May 7, 2020
@jkoritzinsky jkoritzinsky deleted the holders branch May 7, 2020 17:24
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants