Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we account for intrinsics which have gtType=TYP_SIMD16 but gtSIMDSize=32 #35904

Merged
merged 1 commit into from
May 7, 2020

Conversation

tannergooding
Copy link
Member

This resolves #35877

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label May 6, 2020
Copy link
Contributor

@CarolEidt CarolEidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@ghost
Copy link

ghost commented May 6, 2020

Hello @tannergooding!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@tannergooding
Copy link
Member Author

runtime (Libraries Test Run checked coreclr Windows_NT x64 Debug) is an unrelated crypto failure

@safern
Copy link
Member

safern commented May 6, 2020

@bartonjs it seems like this is that cryptic error from the OS that happens once in million runs?

    System.Security.Cryptography.Csp.Tests.RSACryptoServiceProviderTests.PublicOnly_DefaultKey [FAIL]
      Internal.Cryptography.CryptoThrowHelper+WindowsCryptographicException : An internal error occurred.
      Stack Trace:
        /_/src/libraries/System.Security.Cryptography.Csp/src/System/Security/Cryptography/CapiHelper.Windows.cs(486,0): at Internal.NativeCrypto.CapiHelper.GenerateKey(SafeProvHandle safeProvHandle, Int32 algID, Int32 flags, UInt32 keySize, SafeKeyHandle& safeKeyHandle)
        /_/src/libraries/System.Security.Cryptography.Csp/src/System/Security/Cryptography/CapiHelper.Windows.cs(746,0): at Internal.NativeCrypto.CapiHelper.GetKeyPairHelper(CspAlgorithmType keyType, CspParameters parameters, Int32 keySize, SafeProvHandle safeProvHandle)
        /_/src/libraries/System.Security.Cryptography.Csp/src/System/Security/Cryptography/RSACryptoServiceProvider.Windows.cs(136,0): at System.Security.Cryptography.RSACryptoServiceProvider.get_SafeKeyHandle()
        /_/src/libraries/System.Security.Cryptography.Csp/src/System/Security/Cryptography/RSACryptoServiceProvider.Windows.cs(235,0): at System.Security.Cryptography.RSACryptoServiceProvider.get_PublicOnly()
        /_/src/libraries/System.Security.Cryptography.Csp/tests/RSACryptoServiceProviderTests.cs(31,0): at System.Security.Cryptography.Csp.Tests.RSACryptoServiceProviderTests.PublicOnly_DefaultKey()

It seems like this is the only instance in 200 runs.

@bartonjs
Copy link
Member

bartonjs commented May 6, 2020

it seems like this is that cryptic error from the OS that happens once in million runs?

Yep. I've tried getting OS support from it, they say it's unique to the abuse that test machines have and real callers never see problems like that. Makes it hard to do anything other than let the OS error leak out.

@danmoseley
Copy link
Member

@jaredpar another example where we have an unavoidable test failure that we need to be resilient around.

@tannergooding
Copy link
Member Author

jitstress failure on is also a separate issue: #35798 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failure: Assertion failed '(jitIntrinsic->gtSIMDSize == 12) || (jitIntrinsic->gtSIMDSize == 16)'
6 participants