Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compress mono builds that don't run tests to single jobs #37373

Merged
merged 3 commits into from
Jun 4, 2020
Merged

Compress mono builds that don't run tests to single jobs #37373

merged 3 commits into from
Jun 4, 2020

Conversation

safern
Copy link
Member

@safern safern commented Jun 4, 2020

This creates a single leg for each build using Mono that doesn't run tests.

The reason why I didn't change the ones that run tests is because more work is needed on those since we need to build tests and run them. I will work on that and put up a PR once this is merged.

Also, official builds need a little more work.

Test rolling build is here: https://dev.azure.com/dnceng/public/_build/results?buildId=670858&view=results

FYI: @joperezr as you're doing similar changes in: dotnet/runtimelab#2

@ghost
Copy link

ghost commented Jun 4, 2020

Tagging subscribers to this area: @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@safern safern requested review from directhex and a team June 4, 2020 00:32
@safern
Copy link
Member Author

safern commented Jun 4, 2020 •
edited
Loading

I just diffed the expanded ymls from before this change and after this change.

Rolling build went down from 168 jobs to 123
PR Build went down from 164 jobs to 119.
😄

The reason why the PR shows 187 is because I queued a manual build from this branch + the perf legs + live-build leg.

@marek-safar marek-safar requested a review from akoeplinger June 4, 2020 11:48
akoeplinger
akoeplinger reviewed Jun 4, 2020
View reviewed changes
Copy link
Member

@akoeplinger akoeplinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good progress! I'll let Jo do the final approval :)

jashook
jashook approved these changes Jun 4, 2020
View reviewed changes
Copy link
Contributor

@jashook jashook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @safern it lgtm I have restarted testing in case the merge with dev/infra causes weird problems

@jashook
Copy link
Contributor

jashook commented Jun 4, 2020 •
edited
Loading

https://dev.azure.com/dnceng/public/_build/results?buildId=671717&view=results

@jashook
Copy link
Contributor

jashook commented Jun 4, 2020

Something seems strange with the test jobs that get created. Looking into it a little more

joperezr
joperezr approved these changes Jun 4, 2020
View reviewed changes
Copy link
Member

@joperezr joperezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM and my comments are minor, so if this is ready to go feel free to merge and I'll fix those NITs on the PR I have open.

@safern
Copy link
Member Author

safern commented Jun 4, 2020 •
edited
Loading

New build https://dev.azure.com/dnceng/public/_build/results?buildId=671871&view=results

@safern
Copy link
Member Author

safern commented Jun 4, 2020

After merging with master and getting the improvements made to the coreclr test builds in the dev/infrastructure branch new numbers are:

Rolling build 115 jobs
PR build 111 jobs

@safern
Copy link
Member Author

safern commented Jun 4, 2020

FYI: @Chrisboh @mmitche

@jashook
Copy link
Contributor

jashook commented Jun 4, 2020

Perfect that fixes the test builds. Lgtm thank you!

@safern
Copy link
Member Author

safern commented Jun 4, 2020

Perfect that fixes the test builds. Lgtm thank you!

Yeah, the yml expansion is done from the current branch (it doesn't merge it with master) only the checkout of the sources.

@safern
Copy link
Member Author

safern commented Jun 4, 2020

Failures are unrelated. Merging.

@safern safern merged commit a0c3324 into master Jun 4, 2020
@safern safern deleted the CompressMonoBuilds branch June 4, 2020 22:57
@sandreenko sandreenko mentioned this pull request Jun 5, 2020
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@akoeplinger akoeplinger akoeplinger left review comments

@jaredpar jaredpar jaredpar approved these changes

@directhex directhex directhex approved these changes

@jashook jashook jashook approved these changes

@ViktorHofer ViktorHofer ViktorHofer approved these changes

@joperezr joperezr joperezr approved these changes

Assignees
No one assigned
Labels
area-Infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@safern @jashook @jaredpar @directhex @akoeplinger @ViktorHofer @joperezr @Dotnet-GitSync-Bot