[preview8] Add PNSE on non-Browser for S.R.I.JavaScript and clean up references #39797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…otnet#39629) Fixes dotnet#39593 (cherry picked from commit c652058)
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
Tagging subscribers to this area: @dotnet/ncl |
safern
approved these changes
Jul 22, 2020
lewing
approved these changes
Jul 22, 2020
|
Not worth porting at this point, given it only affects developers working in the branch and they can use the command line as a workaround. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Straight backport of #39629 to the
release/5.0-preview8branch.Fixes #39593 (running System.Net.Http tests in VS on Windows).
Description
Fixes the System.Runtime.InteropServices.JavaScript assembly to correctly build a PNSE version for non-Browser targets.
This allows projects like System.Net.Http that reference this project to work when tests are run in Visual Studio on Windows since the assembly is now there. It required some changes to how the JavaScript .csproj was setup up and referenced.
Customer Impact
Allows developers to run System.Net.Http tests with VS on Windows.
Risk
Low, it only affects developers working on dotnet/runtime.