Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

outerloop fix. #44554

Merged
merged 1 commit into from
Nov 12, 2020
Merged

outerloop fix. #44554

merged 1 commit into from
Nov 12, 2020

Conversation

sandreenko
Copy link
Contributor

Apply Santiago's suggestion.

@sandreenko
Copy link
Contributor Author

/azp run runtime-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sandreenko sandreenko marked this pull request as ready for review November 11, 2020 22:43
@sandreenko
Copy link
Contributor Author

sandreenko commented Nov 12, 2020 •
edited
Loading

I have tried the @safern suggestion from #44541 and it gave us the first green outerloop run since July!
PTAL @safern @janvorli @trylek @hoyosjs

The libraries' failures look unrelated but suspicious:

curl: (51) SSL: certificate subject name (*.azureedge.net) does not match target host name 'dotnet.microsoft.com'
Failed to execute 'curl https://dot.net/v1/dotnet-install.sh -sSL --retry 10 --create-dirs -o /datadisks/disk1/workspace/_work/1/s/.dotnet/dotnet-install.sh'. Waiting 3 seconds before next attempt (2 out of 5).

safern
safern reviewed Nov 12, 2020
View reviewed changes
src/tests/Common/helixpublishwitharcade.proj
@@ -94,7 +94,7 @@

<IncludeDotNetCli>true</IncludeDotNetCli>
<DotNetCliPackageType>runtime</DotNetCliPackageType>
<DotNetCliVersion>$(BundledNETCoreAppPackageVersion)</DotNetCliVersion>
<DotNetCliVersion>5.0.0</DotNetCliVersion>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's open an issue to remember to put this back to parse the global.json file or use BundledNETCoreAppPackageVersion so that we're on an up-to date SDK.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened #44578

@sandreenko sandreenko mentioned this pull request Nov 12, 2020
Closed
@sandreenko sandreenko merged commit 1db961e into dotnet:master Nov 12, 2020
@sandreenko sandreenko deleted the fixOuterloop branch November 12, 2020 05:47
@runfoapp runfoapp bot mentioned this pull request Nov 12, 2020
Open
@ghost ghost locked as resolved and limited conversation to collaborators Dec 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@safern safern safern approved these changes

Assignees
No one assigned
Labels
area-Infrastructure-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sandreenko @safern @Dotnet-GitSync-Bot