Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download Mono AOT workload .nupkg in prepare-artifacts.proj #52247

Merged
merged 2 commits into from
May 4, 2021

Conversation

akoeplinger
Copy link
Member

@akoeplinger akoeplinger commented May 4, 2021

Fixes the official build failure after #51327 since the pattern we were using didn't include it.

Note: it sounds wrong to have these in RuntimeNupkgFile but I'm sending the PR to unblock the official build, we'll refactor it in a follow-up PR.

Test official build: https://dev.azure.com/dnceng/internal/_build/results?buildId=1120630&view=results

Fixes the official build failure since the pattern we were using didn't include it.
@ViktorHofer
Copy link
Member

Are the Microsoft.NET.Sdk.Mono.Toolchain.Manifest.*.nupkg packages rid agnostic or specific?

@akoeplinger
Copy link
Member Author

They're rid-agnostic, it's basically Microsoft.NET.Sdk.Mono.Toolchain.Manifest.6.0.0-preview.5.21253.8.nupkg

@ViktorHofer
Copy link
Member

Cool. Can you please add to this item instead then?

<RidAgnosticNupkgToPublishFile

@ViktorHofer
Copy link
Member

Should we queue an official build to make sure this mitigates the build break?

@akoeplinger
Copy link
Member Author

@ViktorHofer I queued one here (before your feedback): https://dev.azure.com/dnceng/internal/_build/results?buildId=1120630&view=results

Do you think we need another one after your feedback? Seems unlikely to break :)

@ViktorHofer
Copy link
Member

Don't think we need another build. I believe the whole logic in this file is outdated and the separation of items actually doesn't do much.

@akoeplinger
Copy link
Member Author

Official build passed, merging.

@akoeplinger akoeplinger merged commit 9e685b2 into dotnet:main May 4, 2021
@akoeplinger akoeplinger deleted the fix-official-build branch May 4, 2021 17:19
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jun 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants