-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI fix for native aot tests #69571
Merged
Merged
CI fix for native aot tests #69571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oh interesting, the x64 checked NativeAOT failure is probably some CoreCLR bug in .NET 7 Preview 3 that we're using to run ilc.exe. I've not seen it before and we'll need to keep an eye for it. It's definitely unrelated to anything this pull request is touching. Filed #69593.
|
src/libraries/Common/tests/SingleFileTestRunner/SingleFileTestRunner.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/tests/SingleFileTestRunner/SingleFileTestRunner.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/tests/SingleFileTestRunner/SingleFileTestRunner.cs
Outdated
Show resolved
Hide resolved
These make `git blame` harder to follow. Plus the consistent thing in this file is no extra newline here.
MichalStrehovsky
approved these changes
May 26, 2022
Close/reopen to trigger CI. Infra was all red. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #69476