Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning/suppression parity with IL Linker #1591

Open
MichalStrehovsky opened this issue Sep 23, 2021 · 0 comments
Open

Warning/suppression parity with IL Linker #1591

MichalStrehovsky opened this issue Sep 23, 2021 · 0 comments
Labels
area-NativeAOT-coreclr .NET runtime optimized for ahead of time compilation

Comments

@MichalStrehovsky
Copy link
Member

  • We generate fewer reflection-safety warnings than IL Linker.
  • We don't respect all the ways the warnings get suppressed.

This requires a bit of work. Warning generation and suppression is spread around the illinker codebase (bunch of it in MarkStep.cs) and tied to concepts like the MarkStack that makes it difficult to replicate in NativeAOT codebase.

This should ideally be in a centralized component that we can eventually share.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-NativeAOT-coreclr .NET runtime optimized for ahead of time compilation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MichalStrehovsky