Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Naming of the properties that control implicit namespaces included by the SDK #18839

Closed
JunTaoLuo opened this issue Jul 9, 2021 · 1 comment
Closed

Naming of the properties that control implicit namespaces included by the SDK #18839

JunTaoLuo opened this issue Jul 9, 2021 · 1 comment
Labels
Area-ImplicitUsings Area-NetSDK Area-WebSDK untriaged Request triage from a team member

Comments

@JunTaoLuo
Copy link
Contributor

Follow up to the conversation started in #18459 (comment).

We don't like the underscore in the naming of the properties that control the list of implicit imports. For example, we have the name <DisableImplicitNamespaceImports_Web>. However, we also need to ensure that these options are very specific and unlikely to collide with other properties.

FYI @mhutch @DamianEdwards @davidfowl
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Request triage from a team member label Jul 9, 2021
@mhutch mhutch mentioned this issue Aug 11, 2021
Closed
12 tasks
@pranavkm
Copy link
Contributor

Closing this since it's been shipped. 👋🏽 @JunTaoLuo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-ImplicitUsings Area-NetSDK Area-WebSDK untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pranavkm @JunTaoLuo @marcpopMSFT