Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a block to prevent multiple workload install, uninstall, repair, restore, or upgrade steps from happening at the same time #18992

Open
Tracked by #14957
marcpopMSFT opened this issue Jul 16, 2021 · 3 comments

Comments

@marcpopMSFT
Copy link
Member

No description provided.

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Request triage from a team member label Jul 16, 2021
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@marcpopMSFT marcpopMSFT added Area-Workloads and removed untriaged Request triage from a team member labels Jul 16, 2021
@marcpopMSFT marcpopMSFT added this to the 6.0.1xx milestone Jul 16, 2021
@wli3
Copy link

wli3 commented Jul 20, 2021

@dsplaisted

We don't advertise .NET SDK to be able to run in parallel.

Doing lock this late makes me nervous. If there is a bug -- for example the lock file on disk does not get cleaned up, so .NET SDK is locked forever -- it is usually hard to discover

@dsplaisted
Copy link
Member

When we discussed it in one of our workloads meetings, we were worried that if two installations did end up running in parallel, we might get into an unrecoverable state. So we wanted to protect against this.

I think we said that we can use a mutex instead of a lock file, which I think will automatically be released when the process exits.

@marcpopMSFT marcpopMSFT modified the milestones: 6.0.1xx, 7.0.1xx Oct 13, 2021
@marcpopMSFT marcpopMSFT modified the milestones: 7.0.1xx, Backlog Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants