Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APICompat.Task targets file should be validated in CI #28300

Closed
ViktorHofer opened this issue Oct 3, 2022 · 4 comments
Closed

APICompat.Task targets file should be validated in CI #28300

ViktorHofer opened this issue Oct 3, 2022 · 4 comments
Labels
Area-ApiCompat untriaged Request triage from a team member

Comments

@ViktorHofer
Copy link
Member

Apparently, the APICompat.Task.targets file in the build folder isn't validated on CI. That was noticed in 0a1f5cd.
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compatibility untriaged Request triage from a team member labels Oct 3, 2022
@ghost
Copy link

ghost commented Oct 3, 2022

@dotnet/area-infrastructure-libraries a new issue has been filed in the ApiCompat area, please triage

@ViktorHofer ViktorHofer mentioned this issue Oct 3, 2022
Merged
@ericstj
Copy link
Member

ericstj commented Oct 3, 2022

Is it straight forward to produce a test assembly which references this (either through package or direct targets import) in the SDK's test infrastructure?

@ViktorHofer
Copy link
Member Author

I believe existing tests already do validate the msbuild file but are disabled because of #23533.

@smasher164
Copy link
Member

Closing as duplicate of #23533.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-ApiCompat untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ViktorHofer @ericstj @smasher164