Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.0.2xx] Change Global Property Flow to Not Flow Publish* Properties #28645

Open
nagilson opened this issue Oct 18, 2022 · 3 comments
Open

[7.0.2xx] Change Global Property Flow to Not Flow Publish* Properties #28645

nagilson opened this issue Oct 18, 2022 · 3 comments
Assignees
Labels
Area-External enhancement Priority:2 Work that is important, but not critical for the release

Comments

@nagilson
Copy link
Member

nagilson commented Oct 18, 2022

Per #28628, we would like to make a better fix for this as some publish properties should likely not be flowing into libraries. We would like to create a list of these properties to check in RuntimeIdentiferInference.targets (SelfContained, PublishAsSingleFile, etc, and PublishSelfContained once that's merged.)

Then we will check against that list instead of having them hardcoded.

At the same time, we will need to flow that list into MSBuild and add a check to see if that list exists, because MSBuild can run with SDKs besides the .NET SDK. If the list does exist, we will need to undefine the properties in a grand total of 3 locations as reflected in this PR: dotnet/msbuild#6924

We aren't doing this fix for 7.0.1xx GA because it's too risky, so doing it in 7.0.2xx.

cc @dsplaisted @rainersigwald

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Request triage from a team member label Oct 18, 2022
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@nagilson nagilson self-assigned this Oct 18, 2022
@nagilson nagilson added Priority:2 Work that is important, but not critical for the release enhancement Area-External and removed untriaged Request triage from a team member labels Oct 18, 2022
@rainersigwald
Copy link
Member

One thing to think about is the solution build--if we unconditionally remove these from p2p refs, we'll be recreating the rid-in-solution thing (#828 (comment)), where I think things like PublishSelfContained aren't unreasonable to specify for a solution build.

@dsplaisted
Copy link
Member

We would want to block the flow of these properties to Rid Agnostic projects. If a project accepts a RuntimeIdentifier, then these properties would also flow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-External enhancement Priority:2 Work that is important, but not critical for the release
Projects
None yet
Development

No branches or pull requests

3 participants