You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Per #28628, we would like to make a better fix for this as some publish properties should likely not be flowing into libraries. We would like to create a list of these properties to check in RuntimeIdentiferInference.targets (SelfContained, PublishAsSingleFile, etc, and PublishSelfContained once that's merged.)
Then we will check against that list instead of having them hardcoded.
At the same time, we will need to flow that list into MSBuild and add a check to see if that list exists, because MSBuild can run with SDKs besides the .NET SDK. If the list does exist, we will need to undefine the properties in a grand total of 3 locations as reflected in this PR: dotnet/msbuild#6924
We aren't doing this fix for 7.0.1xx GA because it's too risky, so doing it in 7.0.2xx.
One thing to think about is the solution build--if we unconditionally remove these from p2p refs, we'll be recreating the rid-in-solution thing (#828 (comment)), where I think things like PublishSelfContained aren't unreasonable to specify for a solution build.
We would want to block the flow of these properties to Rid Agnostic projects. If a project accepts a RuntimeIdentifier, then these properties would also flow.
Per #28628, we would like to make a better fix for this as some publish properties should likely not be flowing into libraries. We would like to create a list of these properties to check in
RuntimeIdentiferInference.targets
(SelfContained
,PublishAsSingleFile
, etc, andPublishSelfContained
once that's merged.)Then we will check against that list instead of having them hardcoded.
At the same time, we will need to flow that list into MSBuild and add a check to see if that list exists, because MSBuild can run with SDKs besides the .NET SDK. If the list does exist, we will need to undefine the properties in a grand total of 3 locations as reflected in this PR: dotnet/msbuild#6924
We aren't doing this fix for 7.0.1xx GA because it's too risky, so doing it in 7.0.2xx.
cc @dsplaisted @rainersigwald
The text was updated successfully, but these errors were encountered: