From 1dd798dbfe5ae65abd6aff0281ac771a2b6ff7c6 Mon Sep 17 00:00:00 2001 From: "dotnet-maestro[bot]" Date: Wed, 16 Jun 2021 15:02:33 +0000 Subject: [PATCH 1/5] Update dependencies from https://github.com/dotnet/runtime build 20210616.2 Microsoft.NETCore.Platforms , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NET.HostModel , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , System.CodeDom , VS.Redist.Common.NetCore.SharedFramework.x64.6.0 From Version 6.0.0-preview.6.21314.2 -> To Version 6.0.0-preview.7.21316.2 --- eng/Version.Details.xml | 52 ++++++++++++++++++++--------------------- eng/Versions.props | 22 ++++++++--------- 2 files changed, 37 insertions(+), 37 deletions(-) diff --git a/eng/Version.Details.xml b/eng/Version.Details.xml index ccbab9facd1c..acf0439ad697 100644 --- a/eng/Version.Details.xml +++ b/eng/Version.Details.xml @@ -25,37 +25,37 @@ https://github.com/dotnet/templating d2bbca27dbe1b65b0a14102c6c8078a525f7b39f - + https://github.com/dotnet/runtime - bc16a7bd2dcca7f1f8ce70e75dc86a3fac3ffcd2 + 6b015e2e24461313622575ca56fb76d4ad469ab5 - + https://github.com/dotnet/runtime - bc16a7bd2dcca7f1f8ce70e75dc86a3fac3ffcd2 + 6b015e2e24461313622575ca56fb76d4ad469ab5 - + https://github.com/dotnet/runtime - bc16a7bd2dcca7f1f8ce70e75dc86a3fac3ffcd2 + 6b015e2e24461313622575ca56fb76d4ad469ab5 - + https://github.com/dotnet/runtime - bc16a7bd2dcca7f1f8ce70e75dc86a3fac3ffcd2 + 6b015e2e24461313622575ca56fb76d4ad469ab5 - + https://github.com/dotnet/runtime - bc16a7bd2dcca7f1f8ce70e75dc86a3fac3ffcd2 + 6b015e2e24461313622575ca56fb76d4ad469ab5 - + https://github.com/dotnet/runtime - bc16a7bd2dcca7f1f8ce70e75dc86a3fac3ffcd2 + 6b015e2e24461313622575ca56fb76d4ad469ab5 - + https://github.com/dotnet/runtime - bc16a7bd2dcca7f1f8ce70e75dc86a3fac3ffcd2 + 6b015e2e24461313622575ca56fb76d4ad469ab5 - + https://github.com/dotnet/runtime - bc16a7bd2dcca7f1f8ce70e75dc86a3fac3ffcd2 + 6b015e2e24461313622575ca56fb76d4ad469ab5 https://github.com/dotnet/msbuild @@ -109,21 +109,21 @@ https://github.com/mono/linker f90f5c929054d4b4b69da0a21db4f69aa64d63af - + https://github.com/dotnet/runtime - bc16a7bd2dcca7f1f8ce70e75dc86a3fac3ffcd2 + 6b015e2e24461313622575ca56fb76d4ad469ab5 - + https://github.com/dotnet/runtime - bc16a7bd2dcca7f1f8ce70e75dc86a3fac3ffcd2 + 6b015e2e24461313622575ca56fb76d4ad469ab5 - + https://github.com/dotnet/runtime - bc16a7bd2dcca7f1f8ce70e75dc86a3fac3ffcd2 + 6b015e2e24461313622575ca56fb76d4ad469ab5 - + https://github.com/dotnet/runtime - bc16a7bd2dcca7f1f8ce70e75dc86a3fac3ffcd2 + 6b015e2e24461313622575ca56fb76d4ad469ab5 https://github.com/dotnet/windowsdesktop @@ -236,9 +236,9 @@ https://github.com/dotnet/arcade fc067a0928f1c8ca4ab3471e9f8edb592e96dec4 - + https://github.com/dotnet/runtime - bc16a7bd2dcca7f1f8ce70e75dc86a3fac3ffcd2 + 6b015e2e24461313622575ca56fb76d4ad469ab5 diff --git a/eng/Versions.props b/eng/Versions.props index 2978e4930c6b..8c22ff9eaf70 100644 --- a/eng/Versions.props +++ b/eng/Versions.props @@ -31,24 +31,24 @@ 5.0.0 6.0.0-beta.21314.1 3.1.0 - 6.0.0-preview.6.21314.2 + 6.0.0-preview.7.21316.2 4.3.0 4.3.0 4.0.5 4.7.2 - 6.0.0-preview.6.21314.2 + 6.0.0-preview.7.21316.2 1.0.0-preview1.1.21112.1 4.6.0 - 6.0.0-preview.6.21314.2 - 6.0.0-preview.6.21314.2 - 6.0.0-preview.6.21314.2 + 6.0.0-preview.7.21316.2 + 6.0.0-preview.7.21316.2 + 6.0.0-preview.7.21316.2 $(MicrosoftNETCoreAppRuntimewinx64PackageVersion) - 6.0.0-preview.6.21314.2 - 6.0.0-preview.6.21314.2 - 6.0.0-preview.6.21314.2 + 6.0.0-preview.7.21316.2 + 6.0.0-preview.7.21316.2 + 6.0.0-preview.7.21316.2 $(MicrosoftExtensionsDependencyModelPackageVersion) @@ -80,10 +80,10 @@ - 6.0.0-preview.6.21314.2 - 6.0.0-preview.6.21314.2 + 6.0.0-preview.7.21316.2 + 6.0.0-preview.7.21316.2 5.0.0-preview.7.20364.11 - 6.0.0-preview.6.21314.2 + 6.0.0-preview.7.21316.2 From 1120121998cda06ffe96cd560aac5ececb5fd7d3 Mon Sep 17 00:00:00 2001 From: Jacques Eloff Date: Wed, 16 Jun 2021 10:01:09 -0700 Subject: [PATCH 2/5] Fix analyzer errors --- src/Cli/Microsoft.DotNet.Cli.Utils/Windows.cs | 4 ++++ .../WindowsRegistryEnvironmentPathEditor.cs | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/src/Cli/Microsoft.DotNet.Cli.Utils/Windows.cs b/src/Cli/Microsoft.DotNet.Cli.Utils/Windows.cs index 3ca0caf5ec14..4a27c217ab45 100644 --- a/src/Cli/Microsoft.DotNet.Cli.Utils/Windows.cs +++ b/src/Cli/Microsoft.DotNet.Cli.Utils/Windows.cs @@ -2,6 +2,7 @@ // Licensed under the MIT license. See LICENSE file in the project root for full license information. // +using System.Runtime.Versioning; using System.Security.Principal; using System.Threading; @@ -10,6 +11,9 @@ namespace Microsoft.DotNet.Cli.Utils /// /// Utility methods, specific to Windows. /// +#if NET + [SupportedOSPlatform("windows")] +#endif public static class Windows { /// diff --git a/src/Cli/Microsoft.DotNet.Cli.Utils/WindowsRegistryEnvironmentPathEditor.cs b/src/Cli/Microsoft.DotNet.Cli.Utils/WindowsRegistryEnvironmentPathEditor.cs index 484a03fea0f3..1237aac7bb3b 100644 --- a/src/Cli/Microsoft.DotNet.Cli.Utils/WindowsRegistryEnvironmentPathEditor.cs +++ b/src/Cli/Microsoft.DotNet.Cli.Utils/WindowsRegistryEnvironmentPathEditor.cs @@ -6,12 +6,16 @@ using System.IO; using System.Linq; using System.Runtime.InteropServices; +using System.Runtime.Versioning; using System.Security.Principal; using System.Threading.Tasks; using Microsoft.Win32; namespace Microsoft.DotNet.Cli.Utils { +#if NET + [SupportedOSPlatform("windows")] +#endif internal class WindowsRegistryEnvironmentPathEditor : IWindowsRegistryEnvironmentPathEditor { private static string Path = "PATH"; From 62b3c0407840220259647f9505d2417f80deebf9 Mon Sep 17 00:00:00 2001 From: Jacques Eloff Date: Wed, 16 Jun 2021 13:58:07 -0700 Subject: [PATCH 3/5] Suppress analyzer warnings --- src/Cli/Microsoft.DotNet.Cli.Utils/DependencyProvider.cs | 2 ++ .../WindowsRegistryEnvironmentPathEditor.cs | 6 ++---- .../MsiWorkloadInstallationRecordManager.cs | 3 +++ .../DependencyProviderTests.cs | 2 ++ .../dotnet-workload-list.Tests/GivenAnMsiInstallation.cs | 2 ++ 5 files changed, 11 insertions(+), 4 deletions(-) diff --git a/src/Cli/Microsoft.DotNet.Cli.Utils/DependencyProvider.cs b/src/Cli/Microsoft.DotNet.Cli.Utils/DependencyProvider.cs index fe9953168335..d4b3fbf8be3f 100644 --- a/src/Cli/Microsoft.DotNet.Cli.Utils/DependencyProvider.cs +++ b/src/Cli/Microsoft.DotNet.Cli.Utils/DependencyProvider.cs @@ -24,6 +24,7 @@ namespace Microsoft.DotNet.Cli.Utils /// dependent entry. If there are no other dependents, it can proceed to remove the MSI, otherwise it should do nothing. /// /// +#pragma warning disable CA1416 public sealed class DependencyProvider { /// @@ -159,4 +160,5 @@ private IEnumerable GetDependents() return dependentsKey?.GetSubKeyNames() ?? Enumerable.Empty(); } } +#pragma warning restore CA1416 } diff --git a/src/Cli/Microsoft.DotNet.Cli.Utils/WindowsRegistryEnvironmentPathEditor.cs b/src/Cli/Microsoft.DotNet.Cli.Utils/WindowsRegistryEnvironmentPathEditor.cs index 1237aac7bb3b..c423cb4b0b2b 100644 --- a/src/Cli/Microsoft.DotNet.Cli.Utils/WindowsRegistryEnvironmentPathEditor.cs +++ b/src/Cli/Microsoft.DotNet.Cli.Utils/WindowsRegistryEnvironmentPathEditor.cs @@ -6,16 +6,13 @@ using System.IO; using System.Linq; using System.Runtime.InteropServices; -using System.Runtime.Versioning; using System.Security.Principal; using System.Threading.Tasks; using Microsoft.Win32; namespace Microsoft.DotNet.Cli.Utils { -#if NET - [SupportedOSPlatform("windows")] -#endif +#pragma warning disable CA1416 internal class WindowsRegistryEnvironmentPathEditor : IWindowsRegistryEnvironmentPathEditor { private static string Path = "PATH"; @@ -76,4 +73,5 @@ private static RegistryKey OpenEnvironmentKeyIfExists(bool writable, SdkEnvironm private const int HWND_BROADCAST = 0xffff; private const int WM_SETTINGCHANGE = 0x001A; } +#pragma warning restore CA1416 } diff --git a/src/Cli/dotnet/commands/dotnet-workload/install/WorkloadInstallRecords/MsiWorkloadInstallationRecordManager.cs b/src/Cli/dotnet/commands/dotnet-workload/install/WorkloadInstallRecords/MsiWorkloadInstallationRecordManager.cs index a750dc0d8de4..aaeca81e91c1 100644 --- a/src/Cli/dotnet/commands/dotnet-workload/install/WorkloadInstallRecords/MsiWorkloadInstallationRecordManager.cs +++ b/src/Cli/dotnet/commands/dotnet-workload/install/WorkloadInstallRecords/MsiWorkloadInstallationRecordManager.cs @@ -1,5 +1,6 @@ // Copyright (c) .NET Foundation and contributors. All rights reserved. // Licensed under the MIT license. See LICENSE file in the project root for full license information. +#nullable disable using System.Collections.Generic; using System.IO; @@ -9,6 +10,7 @@ namespace Microsoft.DotNet.Workloads.Workload.Install.InstallRecord { +#pragma warning disable CA1416 internal class MsiWorkloadInstallationRecordManager : IWorkloadInstallationRecordRepository { /// @@ -62,4 +64,5 @@ public void WriteWorkloadInstallationRecord(WorkloadId workloadId, SdkFeatureBan using RegistryKey wrk = _baseKey.CreateSubKey(Path.Combine(BasePath, $"{sdkFeatureBand}", $"{workloadId}")); } } +#pragma warning restore CA1416 } diff --git a/src/Tests/Microsoft.DotNet.Cli.Utils.Tests/DependencyProviderTests.cs b/src/Tests/Microsoft.DotNet.Cli.Utils.Tests/DependencyProviderTests.cs index 99ba98f7866c..d57ec0f2b5e8 100644 --- a/src/Tests/Microsoft.DotNet.Cli.Utils.Tests/DependencyProviderTests.cs +++ b/src/Tests/Microsoft.DotNet.Cli.Utils.Tests/DependencyProviderTests.cs @@ -9,6 +9,7 @@ namespace Microsoft.DotNet.Cli.Utils.Tests { +#pragma warning disable CA1416 public class DependencyProviderTests { [WindowsOnlyTheory] @@ -96,4 +97,5 @@ public void ItWillNotRemoveTheProviderIfOtherDependentsExist() } } } +#pragma warning restore CA1416 } diff --git a/src/Tests/dotnet-workload-list.Tests/GivenAnMsiInstallation.cs b/src/Tests/dotnet-workload-list.Tests/GivenAnMsiInstallation.cs index 2f08df63fbf0..d83f99168622 100644 --- a/src/Tests/dotnet-workload-list.Tests/GivenAnMsiInstallation.cs +++ b/src/Tests/dotnet-workload-list.Tests/GivenAnMsiInstallation.cs @@ -11,6 +11,7 @@ namespace Microsoft.DotNet.Cli.Workload.List.Tests { +#pragma warning disable CA1416 [Collection("MsiWorkloadRecords")] public class GivenAnMsiInstallation : IDisposable { @@ -71,4 +72,5 @@ private void CreateWorkloadRecord(string sdkFeatureBand, string workloadId) RecordManager.WriteWorkloadInstallationRecord(new WorkloadId(workloadId), new SdkFeatureBand(sdkFeatureBand)); } } +#pragma warning restore CA1416 } From 9cffbf97bb278699616317814f89895839f1d5d5 Mon Sep 17 00:00:00 2001 From: "dotnet-maestro[bot]" Date: Thu, 17 Jun 2021 12:23:19 +0000 Subject: [PATCH 4/5] Update dependencies from https://github.com/dotnet/runtime build 20210617.1 Microsoft.NETCore.Platforms , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NET.HostModel , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , System.CodeDom , VS.Redist.Common.NetCore.SharedFramework.x64.6.0 From Version 6.0.0-preview.6.21314.2 -> To Version 6.0.0-preview.7.21317.1 --- eng/Version.Details.xml | 52 ++++++++++++++++++++--------------------- eng/Versions.props | 22 ++++++++--------- 2 files changed, 37 insertions(+), 37 deletions(-) diff --git a/eng/Version.Details.xml b/eng/Version.Details.xml index acf0439ad697..3763547026e0 100644 --- a/eng/Version.Details.xml +++ b/eng/Version.Details.xml @@ -25,37 +25,37 @@ https://github.com/dotnet/templating d2bbca27dbe1b65b0a14102c6c8078a525f7b39f - + https://github.com/dotnet/runtime - 6b015e2e24461313622575ca56fb76d4ad469ab5 + 96a4671bc52e70024da409f5f48b0abaa30cb901 - + https://github.com/dotnet/runtime - 6b015e2e24461313622575ca56fb76d4ad469ab5 + 96a4671bc52e70024da409f5f48b0abaa30cb901 - + https://github.com/dotnet/runtime - 6b015e2e24461313622575ca56fb76d4ad469ab5 + 96a4671bc52e70024da409f5f48b0abaa30cb901 - + https://github.com/dotnet/runtime - 6b015e2e24461313622575ca56fb76d4ad469ab5 + 96a4671bc52e70024da409f5f48b0abaa30cb901 - + https://github.com/dotnet/runtime - 6b015e2e24461313622575ca56fb76d4ad469ab5 + 96a4671bc52e70024da409f5f48b0abaa30cb901 - + https://github.com/dotnet/runtime - 6b015e2e24461313622575ca56fb76d4ad469ab5 + 96a4671bc52e70024da409f5f48b0abaa30cb901 - + https://github.com/dotnet/runtime - 6b015e2e24461313622575ca56fb76d4ad469ab5 + 96a4671bc52e70024da409f5f48b0abaa30cb901 - + https://github.com/dotnet/runtime - 6b015e2e24461313622575ca56fb76d4ad469ab5 + 96a4671bc52e70024da409f5f48b0abaa30cb901 https://github.com/dotnet/msbuild @@ -109,21 +109,21 @@ https://github.com/mono/linker f90f5c929054d4b4b69da0a21db4f69aa64d63af - + https://github.com/dotnet/runtime - 6b015e2e24461313622575ca56fb76d4ad469ab5 + 96a4671bc52e70024da409f5f48b0abaa30cb901 - + https://github.com/dotnet/runtime - 6b015e2e24461313622575ca56fb76d4ad469ab5 + 96a4671bc52e70024da409f5f48b0abaa30cb901 - + https://github.com/dotnet/runtime - 6b015e2e24461313622575ca56fb76d4ad469ab5 + 96a4671bc52e70024da409f5f48b0abaa30cb901 - + https://github.com/dotnet/runtime - 6b015e2e24461313622575ca56fb76d4ad469ab5 + 96a4671bc52e70024da409f5f48b0abaa30cb901 https://github.com/dotnet/windowsdesktop @@ -236,9 +236,9 @@ https://github.com/dotnet/arcade fc067a0928f1c8ca4ab3471e9f8edb592e96dec4 - + https://github.com/dotnet/runtime - 6b015e2e24461313622575ca56fb76d4ad469ab5 + 96a4671bc52e70024da409f5f48b0abaa30cb901 diff --git a/eng/Versions.props b/eng/Versions.props index 8c22ff9eaf70..b39477f6122e 100644 --- a/eng/Versions.props +++ b/eng/Versions.props @@ -31,24 +31,24 @@ 5.0.0 6.0.0-beta.21314.1 3.1.0 - 6.0.0-preview.7.21316.2 + 6.0.0-preview.7.21317.1 4.3.0 4.3.0 4.0.5 4.7.2 - 6.0.0-preview.7.21316.2 + 6.0.0-preview.7.21317.1 1.0.0-preview1.1.21112.1 4.6.0 - 6.0.0-preview.7.21316.2 - 6.0.0-preview.7.21316.2 - 6.0.0-preview.7.21316.2 + 6.0.0-preview.7.21317.1 + 6.0.0-preview.7.21317.1 + 6.0.0-preview.7.21317.1 $(MicrosoftNETCoreAppRuntimewinx64PackageVersion) - 6.0.0-preview.7.21316.2 - 6.0.0-preview.7.21316.2 - 6.0.0-preview.7.21316.2 + 6.0.0-preview.7.21317.1 + 6.0.0-preview.7.21317.1 + 6.0.0-preview.7.21317.1 $(MicrosoftExtensionsDependencyModelPackageVersion) @@ -80,10 +80,10 @@ - 6.0.0-preview.7.21316.2 - 6.0.0-preview.7.21316.2 + 6.0.0-preview.7.21317.1 + 6.0.0-preview.7.21317.1 5.0.0-preview.7.20364.11 - 6.0.0-preview.7.21316.2 + 6.0.0-preview.7.21317.1 From 1c1a0720c556fb5cb4e8c5c7f3570ea2babc54a8 Mon Sep 17 00:00:00 2001 From: Jacques Eloff Date: Thu, 17 Jun 2021 07:47:33 -0700 Subject: [PATCH 5/5] Fix test failure --- .../GivenThatWeWantToCollectExceptionTelemetry.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToCollectExceptionTelemetry.cs b/src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToCollectExceptionTelemetry.cs index 9d7398114733..02dd254129ac 100644 --- a/src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToCollectExceptionTelemetry.cs +++ b/src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToCollectExceptionTelemetry.cs @@ -31,7 +31,7 @@ public void It_collects_Exception() mSBuildCommand .Execute(telemetryTestLogger, causeTaskToFail) .StdOut.Should() - .Contain("\"EventName\":\"taskBaseCatchException\",\"Properties\":{\"exceptionType\":\"System.IO.FileNotFoundException\"") + .Contain("\"EventName\":\"taskBaseCatchException\",\"Properties\":{\"exceptionType\":\"System.IO.IOException\"") .And.Contain("detail"); } }