Multiple ClickOnce versions fail to be signed #760
Labels
area-clickonce
Related to ClickOnce signing
bug
Priority:1
Work that is critical for the release, but we could probably ship without
Describe the bug
When using a git repository to host a ClickOnce project, additional previous versions may exist. This means each version will contain a manifest file so when the sign tool iterates through the
ClickOnceSigner
looking for aSingleOrDefault
manifest to sign, it may find more than one, resulting in the below stack trace.Repro steps
.application
fileProfitEncounter exceptionExpected behavior
I believe two different behaviors are acceptable here per manifest file:
I believe the preference should probably be with the first, but I'm indifferent
Actual behavior
Additional context
Potentially problematic code:
sign/src/Sign.Core/DataFormatSigners/ClickOnceSigner.cs
Lines 125 to 132 in d018f75
This issue happened with at least the three latest versions:
0.9.1-beta.24406.1+6584f5d081d8a06660d58d1a777b2352ff376a68
0.9.1-beta.24170.3
0.9.1-beta.24361.2
The text was updated successfully, but these errors were encountered: