Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider implementing end-to-end testing on the real file system #2580

Closed
AR-May opened this issue Oct 15, 2020 · 1 comment
Closed

Consider implementing end-to-end testing on the real file system #2580

AR-May opened this issue Oct 15, 2020 · 1 comment
Labels
Epic Groups multiple user stories. Can be grouped under a theme. need-investigation The issue needs the second look and more investigation triaged The issue was evaluated by the triage team, placed on correct area, next action defined.

Comments

@AR-May
Copy link
Member

AR-May commented Oct 15, 2020

The current end-to-end tests use an in-memory file system. Hence, some of the features were left untested, such as the run script post-action and the chmod post-action: seems like the corresponding tests could not be written within the current testing infrastructure. We already run into the issue with the absence of these tests: the change in one of our dependencies broke the chmod post-action and that was not noticed that for a long time (PR #1555, PR #2579, issue #1547).

Consider designing and implementing proper end-to-end testing on the real file system for these post-actions.
The second option here is to find a workaround / somehow to leverage the current infrastructure and write proper tests for these post-actions if it is decided not to make end-to-end testing on the real file system.

@AR-May AR-May added Epic Groups multiple user stories. Can be grouped under a theme. need-investigation The issue needs the second look and more investigation labels Oct 15, 2020
@donJoseLuis donJoseLuis added the triaged The issue was evaluated by the triage team, placed on correct area, next action defined. label Oct 19, 2020
@vlada-shubina vlada-shubina removed the triaged The issue was evaluated by the triage team, placed on correct area, next action defined. label Oct 19, 2020
@AR-May AR-May added triaged The issue was evaluated by the triage team, placed on correct area, next action defined. size:5.0 labels Oct 26, 2020
@donJoseLuis
Copy link
Contributor

Abandoned, work tracked via other means.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic Groups multiple user stories. Can be grouped under a theme. need-investigation The issue needs the second look and more investigation triaged The issue was evaluated by the triage team, placed on correct area, next action defined.
Projects
None yet
Development

No branches or pull requests

3 participants