Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use MSBuildProjectFile instead of MSBuildProjectFullPath #254

Open
Tracked by #296
Youssef1313 opened this issue Feb 25, 2021 · 2 comments
Open
Tracked by #296

Use MSBuildProjectFile instead of MSBuildProjectFullPath #254

Youssef1313 opened this issue Feb 25, 2021 · 2 comments
Labels
community reported enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed Triaged Label to show that UA team has triaged this issue. User Story

Comments

@Youssef1313
Copy link
Member

I expect it to fail due to:

upgrade-assistant/src/extensions/default/analyzers/Microsoft.DotNet.UpgradeAssistant.Extensions.Default.CSharp.Analyzers/Microsoft.DotNet.UpgradeAssistant.Extensions.Default.CSharp.Analyzers.csproj

Line 6 in 8e7b431

<PackageId>*$(MSBuildProjectFullPath)*</PackageId>

See dotnet/roslyn-sdk#720 for the fix.
@mjrousos
Copy link
Member

Thanks, @Youssef1313. In general, we haven't prioritized testing on Linux yet since the primary use case of the tool will be updating .NET Framework apps. But the analyzers, at least, should work cross-platform (and it would be cool if the CLI did too at some point), so this will be good to get fixed.

@mjrousos mjrousos added the bug Something isn't working label Feb 25, 2021
@sunandabalu sunandabalu changed the title Add Linux CI Use MSBuildProjectFile instead of MSBuildProjectFullPath Apr 20, 2021
@sunandabalu sunandabalu added the Triaged Label to show that UA team has triaged this issue. label Apr 20, 2021
@sunandabalu
Copy link
Member

This fix makes sense, we will be not addressing the Linux CI part of this issue.

@sunandabalu sunandabalu added good first issue Good for newcomers help wanted Extra attention is needed and removed bug Something isn't working labels Apr 20, 2021
@brandonh-msft brandonh-msft mentioned this issue Jul 14, 2022
Closed
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
community reported enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed Triaged Label to show that UA team has triaged this issue. User Story
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mjrousos @sunandabalu @brandonh-msft @Youssef1313