Add commandline to chose VS version #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunandabalu
reviewed
Jul 27, 2021
src/cli/Microsoft.DotNet.UpgradeAssistant.Cli/Commands/Upgrade/ConsoleUpgradeCommand.cs
Outdated
Show resolved
Hide resolved
src/cli/Microsoft.DotNet.UpgradeAssistant.Cli/Commands/UpgradeAssistantCommand.cs
Outdated
Show resolved
Hide resolved
src/cli/Microsoft.DotNet.UpgradeAssistant.Cli/IUpgradeAssistantOptions.cs
Outdated
Show resolved
Hide resolved
|
Is there a way we can throw info about what components are needed if it fails to load the project? |
twsouthwick
force-pushed
the
tasou/select-vs-version
branch
from
f447fb7 to
e4e564d
Compare
|
Not at this time. It's a bootstrapping issue - in order to identify components, we need to load the project. In order to load the project, we need to have the workloads available. |
sunandabalu
approved these changes
Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a commandline
--vs-pathto pass a VS instance through, as well as throwing a useful exception when a target is not available.Fixes #733