Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[.NET 6] [Source Compat Failure] Greenshot & ControlzEx apps doesn't build with .net6.0 SDK #4061

Closed
jiangzeng01 opened this issue Jan 22, 2021 · 7 comments
Assignees
Labels
Investigate Requires further investigation by the WPF team.

Comments

@jiangzeng01
Copy link

Application Name: Greenshot
OS: Windows 10 RS5
CPU: X64
.NET Build Number: 6.0.100-preview.1.21071.10
Project Location: https://github.com/greenshot/greenshot

Verify Scenarios:
1). Windows 10 RS5 X64 + .NET Core SDK build 6.0.100-preview.1.21071.10: Fail
2). Windows 10 RS5 X64 + .NET Core SDK build 5.0.102: Pass

Repro steps

  1. Source Code check at https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1268782
  2. go to src\Greenshot
  3. dotnet build

Expected Result:
Build succeeded

Actual Result:

C:\Users\valtunc\Desktop\AppSources\greenshot\src\Greenshot.Addons\obj\Debug\net5.0-windows\Views\ExportNotificationView.g.cs(49,18): error CS1504: Source file '..\..\..\Views\ExportNotificationView.xaml' could not be opened -- Could not find file. [C:\Users\valtunc\Desktop\AppSources\greenshot\src\Greenshot.Addons\Greenshot.Addons.csproj]

C:\Users\valtunc\Desktop\AppSources\greenshot\src\Greenshot.Addons\obj\Debug\net5.0-windows\Views\ExportNotificationView.g.cs(70,21): error CS1504: Source file '..\..\..\Views\ExportNotificationView.xaml' could not be opened -- Could not find file. [C:\Users\valtunc\Desktop\AppSources\greenshot\src\Greenshot.Addons\Greenshot.Addons.csproj]
C:\Users\valtunc\Desktop\AppSources\greenshot\src\Greenshot.Addons\obj\Debug\net5.0-windows\Views\FileConfigPartView.g.cs(45,18): error CS1504: Source file '..\..\..\Views\FileConfigPartView.xaml' could not be opened -- Could not find file. [C:\Users\valtunc\Desktop\AppSources\greenshot\src\Greenshot.Addons\Greenshot.Addons.csproj]
C:\Users\valtunc\Desktop\AppSources\greenshot\src\Greenshot.Addons\obj\Debug\net5.0-windows\Views\FileConfigPartView.g.cs(66,21): error CS1504: Source file '..\..\..\Views\FileConfigPartView.xaml' could not be opened -- Could not find file. [C:\Users\valtunc\Desktop\AppSources\greenshot\src\Greenshot.Addons\Greenshot.Addons.csproj]
C:\Users\valtunc\Desktop\AppSources\greenshot\src\Greenshot.Addons\obj\Debug\net5.0-windows\Views\UploadView.g.cs(58,21): error CS1504: Source file '..\..\..\Views\UploadView.xaml' could not be opened -- Could not find file. [C:\Users\valtunc\Desktop\AppSources\greenshot\src\Greenshot.Addons\Greenshot.Addons.csproj]
    95 Warning(s)
    5 Error(s)

@dotnet-actwx-bot @dotnet/compat

@jiangzeng01
Copy link
Author

@ryalanms This issue was fixed for .NET 5 and now regressed in .NET 6.
#3628

Are you going to revert the change or fix the issue for .NET 6?

@jiangzeng01 jiangzeng01 changed the title [.NET 6] [Source Compat Failure] Greenshot app doesn't build with .net6.0 SDK [.NET 6] [Source Compat Failure] Greenshot & ControlzEx apps doesn't build with .net6.0 SDK Jan 22, 2021
@ryalanms
Copy link
Member

ryalanms commented Jan 22, 2021

You may be hitting a NET SDK change that impacts the import order of Directory.Build.props.

@ryalanms ryalanms added the Investigate Requires further investigation by the WPF team. label Jan 22, 2021
@ryalanms
Copy link
Member

Can you test this with the most recent version of the SDK? Thanks.

@jiangzeng01
Copy link
Author

@ryalanms We will try with last version and let you know

@dsplaisted
Copy link
Member

@ryalanms This doesn't look like it is at all related to the Directory.Build.targets breaking change (see dotnet/sdk#15449). The greenshot repo doesn't even have a Directory.Build.targets file.

Was there another change you thought might have fixed this?

@ryalanms
Copy link
Member

@dsplaisted: Yes, this is unrelated to Directory.Build.targets and is fixed in recent builds. I confirmed with build 6.0.100-preview.1.21073.4.

@jiangzeng01
Copy link
Author

Close this issue as verified.

@ghost ghost locked as resolved and limited conversation to collaborators Apr 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Investigate Requires further investigation by the WPF team.
Projects
None yet
Development

No branches or pull requests

4 participants
@dsplaisted @ryalanms @jiangzeng01 and others