Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestStarted event is not raised #54

Closed
mandel-macaque opened this issue Apr 21, 2020 · 0 comments · Fixed by #59
Closed

TestStarted event is not raised #54

mandel-macaque opened this issue Apr 21, 2020 · 0 comments · Fixed by #59
Assignees
@mandel-macaque
Labels
test-runners TestRunner area

Comments

@mandel-macaque
Copy link
Member

All other test events are raised but the TestStarted one. This is a blocker for the mono team.
@mandel-macaque mandel-macaque added the test-runners TestRunner area label Apr 21, 2020
@mandel-macaque mandel-macaque self-assigned this Apr 21, 2020
@mandel-macaque mandel-macaque changed the title [Runners] TestStsrted event is not raised [Runners] TestStarted event is not raised Apr 21, 2020
mandel-macaque added a commit to mandel-macaque/xharness that referenced this issue Apr 21, 2020
@mandel-macaque
[Runners] Raise the start event before the tests executes.
0015f10 
The OnTestStarted was being called in the HandleAfterTestStarting. That
means that the event might not be raised if there is an issue with the
test setup, making it hard to track. Moved the call to the
HandleBeforeTestStarting to notify the test is going to strat which will
execute before any issue occurs.

fixes: dotnet#54
@mandel-macaque mandel-macaque mentioned this issue Apr 21, 2020
Merged
mandel-macaque added a commit that referenced this issue Apr 22, 2020
@mandel-macaque
[Runners] Raise the start event before the tests executes. (#59)
9d7c784 
The OnTestStarted was being called in the HandleAfterTestStarting. That
means that the event might not be raised if there is an issue with the
test setup, making it hard to track. Moved the call to the
HandleBeforeTestStarting to notify the test is going to strat which will
execute before any issue occurs.

fixes: #54
@premun premun changed the title [Runners] TestStarted event is not raised TestStarted event is not raised Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mandel-macaque mandel-macaque

Labels
test-runners TestRunner area
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Runners] Raise the start event before the tests executes. mandel-macaque/xharness
1 participant
@mandel-macaque