Prevent hang of XHarness when Listener doesn't initialize fully #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -347,7 +353,8 @@ public class AppRunner | |||
| } | |||
| } | |||
|
|
|||
| listener.Cancel(); | |||
| // TODO: https://github.com/dotnet/xharness/issues/73 | |||
| // listener.Cancel(); | |||
There was a problem hiding this comment.
Hmm that is annoying. Crazy question, have you tried something int the listener.Cancel to instead of calling the Cancel of the TcpListener to access the Socket and close it? Something like:
server.Server.Close();Is a little brute but might work.
There was a problem hiding this comment.
Thanks, will give it a go
mandel-macaque
approved these changes
Apr 23, 2020
|
@mandel-macaque I had something like this: But then I realized the timeout actually works, just the hang is after. I am also thinking of not setting any timeout inside the AppRunner and controlling it through cancellationToken from the CLI |
|
I merged this so that Egor has something to work with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a final fix but rather unblock for others.
More information about the hang here:
#73