Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SslStream on Unix might starve thread pool under load #108

Closed
dv00d00 opened this issue Apr 26, 2020 · 1 comment
Closed

SslStream on Unix might starve thread pool under load #108

dv00d00 opened this issue Apr 26, 2020 · 1 comment
Labels
External: Runtime This work will mostly be done in the dotnet/runtime repo Type: Discussion This issue is a discussion thread and doesn't currently represent actionable work.
Milestone
YARP 1.0.0

Comments

@dv00d00
Copy link

dv00d00 commented Apr 26, 2020

I've recently encountered a thread pool starvation in Kestrel. @davidfowl helped me to debug the issue and it looks like SslStream was the bad player (dotnet/aspnetcore#21183)

TLDR: on restart under load, every https request was waiting on return task.GetAwaiter().GetResult();

Would it be possible to fix it before 1.0 release? Docker container would probably be #1 host for reverse proxy and you would have no reason to put another reverse proxy that can handle TLS in front of this one.
@dv00d00 dv00d00 added the Type: Discussion This issue is a discussion thread and doesn't currently represent actionable work. label Apr 26, 2020
@karelz karelz added this to the 1.0.0 milestone May 12, 2020
@karelz karelz added the External: Runtime This work will mostly be done in the dotnet/runtime repo label May 12, 2020
@karelz
Copy link
Member

karelz commented Mar 24, 2021

Duplicate of dotnet/aspnetcore#21183

@karelz karelz marked this as a duplicate of dotnet/aspnetcore#21183 Mar 24, 2021
@karelz karelz closed this as completed Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
External: Runtime This work will mostly be done in the dotnet/runtime repo Type: Discussion This issue is a discussion thread and doesn't currently represent actionable work.
Projects
None yet
Milestone
YARP 1.0.0
Development

No branches or pull requests
2 participants
@dv00d00 @karelz