Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs / Plan for Client cert handling #989

Closed
samsp-msft opened this issue May 11, 2021 · 7 comments · Fixed by #1339
Closed

Docs / Plan for Client cert handling #989

samsp-msft opened this issue May 11, 2021 · 7 comments · Fixed by #1339
Assignees
Labels
Type: Bug Something isn't working
Milestone

Comments

@samsp-msft
Copy link
Member

If the proxy is handling the client cert how does it pass it to the back end server?
Can the proxy do cert auth with the backend so that the backend can trust connections are coming from the proxy

@samsp-msft samsp-msft added the Type: Bug Something isn't working label May 11, 2021
@Tratcher
Copy link
Member

If the proxy is handling the client cert how does it pass it to the back end server?

See https://github.com/microsoft/reverse-proxy/blob/main/src/ReverseProxy/Service/RuntimeModel/Transforms/RequestHeaderClientCertTransform.cs

Can the proxy do cert auth with the backend so that the backend can trust connections are coming from the proxy

See https://microsoft.github.io/reverse-proxy/articles/proxyhttpclientconfig.html#httpclient, though there's a proposal to remove this from the config and only support it via the extensible factory:
#352 (comment)

@karelz karelz added this to the YARP 1.0.0 milestone May 13, 2021
@Tratcher
Copy link
Member

#999
#1031

@alnikola
Copy link
Contributor

alnikola commented Jun 2, 2021

It seems #999 is moved into "Backlog" and #1031 is completed.
@samsp-msft @Tratcher Can we now close this issue as completed?

@Tratcher
Copy link
Member

Tratcher commented Jun 2, 2021

The 3rd question here is if https://microsoft.github.io/reverse-proxy/articles/transforms.html#clientcert is adequate documentation for flowing an external client certificate?

@samsp-msft
Copy link
Member Author

No, I don't think its adequate docs... yet. I think there needs to be a bit more preamble. I'll create a PR.

@samsp-msft
Copy link
Member Author

Triage: Also need to clarify how client certs should be validated.

@karelz
Copy link
Member

karelz commented Oct 26, 2021

Triage: The docs are likely in ASP.NET already - find them and link them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants