fix: Add TypeScript definitions

[ellinge]

Adds TypeScript-definitions

I also noticed that onAction is not correctly implemented. Currently sends a { action: string, id: string }.
There is code in index.js which tries to fetch the node. But it does not seem be working. It expects two parameters but receives the object described above in the first parameter.

Changed the examples/stories to get the node id at least.
Also changed in readme where onAction should be applied.

Fixes #209

• New feature

[coveralls]

Pull Request Test Coverage Report for Build 943

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 94.843%

---

Totals
Change from base Build 915:	0.0%
Covered Lines:	323
Relevant Lines:	333

---

💛 - Coveralls

[ellinge]

Tested with npm install git:

Currently based on develop so radioSelect (and id is missing).

[mrchief]

@ellinge This is really great!

[mrchief]

Are you done with this? It seems like we can merge this and get a release out (will get radio once #217 gets merged).

Also, I think we should separate out action related changes (see my comments regarding them) so that we can get the typings out.

[ellinge]

Are you done with this? It seems like we can merge this and get a release out (will get radio once #217 gets merged).

Also, I think we should separate out action related changes (see my comments regarding them) so that we can get the typings out.

I want to be sure with the typings for onAction first. I think we need to split TreeNode (props and return) as well since the return-object does not include children anymore (it's set to undefined). Should we expose the _id/id props as well?

Do you think we should expose any "internal" props and methods as well. Such as node and searchInput. We actually use them to set the width of the dropdown to the div-node and handling tabbing in and out of the dropdown. I guess others are interested in their expose as well without casting the whole ref to any instead.

TS2339: Property 'handleClick' does not exist on type 'DropdownTreeSelect'.
TS2339: Property 'keepDropdownActive' does not exist on type 'DropdownTreeSelect'.
TS2339: Property 'node' does not exist on type 'DropdownTreeSelect'.
TS2339: Property 'searchInput' does not exist on type 'DropdownTreeSelect'.

[mrchief]

Should we expose the _id/id props as well?

No, since they are internal to the component. If anyone needs id, they can pass their own and the component will use them. I don't want anyone relying on our internal mechanism of generating IDs.

Do you think we should expose any "internal" props and methods as well. Such as node and searchInput. We actually use them to set the width of the dropdown to the div-node and handling tabbing in and out of the dropdown. I guess others are interested in their expose as well without casting the whole ref to any instead.

Let me think about this and I'll get back to you.

[codeclimate]

Code Climate has analyzed commit 3cad026 and detected 0 issues on this pull request.

View more on Code Climate.

[mrchief]

Many thanks for adding this!

[mrchief]

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀