GH username prevents flatpak manifest from building app

[hanaral]

The hyphen in your username prevents flatpak from building with the manifest I made at every level, including:

• The app ID
• The app executable command
• All the icons
• The .desktop file
• All the gschema files

You'll probably have to get your username changed unless there is a solution I don't know about (putting the ID in single/double quotes doesn't work)

[dr-Styki]

Hi @hanaral
This is problematic because flatpak suggest to use the undersore instead of the hyphen, but github only allow the use of hyphen in username. 😥️

[hanaral]

Yeah, it doesn't seem like the issue will go away that easily 😣️
It's probably worth prodding flatpak for this and seeing if there is an actual reason for not allowing this (I have a bad feeling there is), you can't be the only person having this issue...

[smcv]

You can use com.github.dr_styki.screenrec for all the app IDs. Don't change your username on Github, just replace the - with _ wherever you use it as part of a freedesktop.org identifier (AppStream, .desktop file, D-Bus).

This cannot cause a collision with another Github user's app, precisely because the underscore isn't allowed in Github usernames (or DNS names).

The validation rules for D-Bus names were already part of a specification with multiple implementations before this issue became apparent, so for compatibility reasons they cannot change now. Similar backwards-compatibility concerns apply to Flatpak.

The reversed-DNS naming convention in D-Bus was copied from Java, which also doesn't allow underscores or leading digits. Android app IDs are very similar. Presumably Java library and Android app authors with - in their DNS names also have to replace them with _.

[dr-Styki]

Thanks for your feedback, I updated the app name in the last commit 75edd1c. Now you should be able to build the app for flatpak.