Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement BITFIELD_RO #1876

Closed
romange opened this issue Sep 18, 2023 · 7 comments · Fixed by #2222
Closed

implement BITFIELD_RO #1876

romange opened this issue Sep 18, 2023 · 7 comments · Fixed by #2222
Assignees
@kostasrim
Labels
API-6 Redis 6 API enhancement New feature or request good first issue Good for newcomers hacktoberfest Participates in Hacktoberfest help wanted Extra attention is needed

Comments

@romange
Copy link
Collaborator

romange commented Sep 18, 2023

See https://redis.io/commands/bitfield_ro/ for more details
@romange romange added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers API-6 Redis 6 API hacktoberfest Participates in Hacktoberfest labels Sep 18, 2023
@edxlang
Copy link

edxlang commented Sep 19, 2023

Hi, I'd like to work on this!

@romange
Copy link
Collaborator Author

romange commented Sep 19, 2023

Sure, go ahead.

@chakaz
Copy link
Collaborator

chakaz commented Sep 19, 2023

Hi @0xedl, please note that there's also BITFIELD command which is missing:
#213
It might be worth to keep that in mind when implementing, for supporting that as well 🙏

@romange
Copy link
Collaborator Author

romange commented Sep 19, 2023

@chakaz actually BITFIELD is more complicated therefore I actually suggest to start with BITFIELD_RO first and do the refactoring (code reuse) later.

@chakaz
Copy link
Collaborator

chakaz commented Sep 19, 2023

Agreed, just something to keep in mind that's all :)

@Abhra303
Copy link
Contributor

Hi @0xedl , are you working on the issue? If you are, consider opening a draft PR so that other could see and comment on the approach :)

@edxlang
Copy link

edxlang commented Oct 19, 2023

Hi! I will have something ready soon!

@kostasrim kostasrim self-assigned this Nov 27, 2023
@kostasrim kostasrim mentioned this issue Nov 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kostasrim kostasrim

Labels
API-6 Redis 6 API enhancement New feature or request good first issue Good for newcomers hacktoberfest Participates in Hacktoberfest help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(bitops_family): implement bitfield_ro command dragonflydb/dragonfly
5 participants
@romange @chakaz @kostasrim @Abhra303 @edxlang