Skip to content

Commit

Permalink
fix(checkbox): add 'type="button"' to <button> tag
Browse files Browse the repository at this point in the history
Add attribute 'type="button"' to <button> tag. The missing attribute caused forms with

ion-checkboxes to not be submitted as a normal form
  • Loading branch information
rtomchinsky committed Apr 11, 2016
1 parent dad2155 commit 7583ebf
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions ionic/components/checkbox/checkbox.ts
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ const CHECKBOX_VALUE_ACCESSOR = new Provider(
'<div class="checkbox-inner"></div>' +
'</div>' +
'<button role="checkbox" ' +
'type="button" ' +
'[id]="id" ' +
'[attr.aria-checked]="_checked" ' +
'[attr.aria-labelledby]="_labelId" ' +
Expand Down

0 comments on commit 7583ebf

Please sign in to comment.