Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beta7: collection-repeat doesn’t handle items larger than screen size correctly #1621

Closed
udfalkso opened this issue Jun 13, 2014 · 5 comments

Comments

@udfalkso
Copy link

It used to work as expected, but now if the first item in the list is larger than the screen height, subsequent items are not rendered soon enough. It waits until they go off screen before rendering them.

This pen demonstrates:
http://codepen.io/udfalkso/pen/drzFB

For background as to why I would want to do such a weird thing, see my comments here:
#1157 (comment)

Scrolling performance does seem quite improved in the new version, so hopefully this can be sorted out without ruining the gains.

Thanks!
Udi

@ajoslin
Copy link
Contributor

ajoslin commented Jun 13, 2014

Thanks for the report @udfalkso.

I accidentally reverted something that was implemented to fix this exact problem when I was fixing - it will be easy to resolve. I'll get to it today hopefully.

@h4ck3rviv3k
Copy link

Hi @ajoslin could you please suggest what is the solution for this issue

@ajoslin
Copy link
Contributor

ajoslin commented Jun 17, 2014

Fixed! Can you guys try out the nightly build and let me know?

@udfalkso
Copy link
Author

Just tried with v1.0.0-beta.8-nightly-204 and it's working again, thanks!

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 6, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants