Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scroll content not sized properly for "list cards" #1708

Closed
calendee opened this issue Jun 30, 2014 · 7 comments
Closed

scroll content not sized properly for "list cards" #1708

calendee opened this issue Jun 30, 2014 · 7 comments
Assignees
Labels
needs: reply the issue needs a response from the user

Comments

@calendee
Copy link

If content section of view contains cards with the "list" class, the scroll area does not size properly to accommodate them.

CodePen Sample : http://codepen.io/calendee/pen/tBnlJ

You can see in the sample that the card is partially cutoff and the viewport cannot be scrolled all the way do to see it.

<div class="list card">

  <a href="#" class="item item-icon-left">
    <i class="icon ion-home"></i>
    Enter home address
  </a>

  <a href="#" class="item item-icon-left">
    <i class="icon ion-ios7-telephone"></i>
    Enter phone number
  </a>

  <a href="#" class="item item-icon-left">
    <i class="icon ion-wifi"></i>
    Enter wireless password
  </a>

  <a href="#" class="item item-icon-left">
    <i class="icon ion-card"></i>
    Enter card information
  </a>

  <a href="#" class="item item-icon-left">
    <i class="icon ion-home"></i>
    Enter home address 2
  </a>

  <a href="#" class="item item-icon-left">
    <i class="icon ion-ios7-telephone"></i>
    Enter phone number 2
  </a>

  <a href="#" class="item item-icon-left">
    <i class="icon ion-wifi"></i>
    Enter wireless password 2
  </a>

  <a href="#" class="item item-icon-left">
    <i class="icon ion-card"></i>
    Enter card information 2
  </a>

</div>
@perrygovier
Copy link
Contributor

Hey @calendee, I can reproduce it, thanks.

It looks like it only happens when I use the class list and card together. Trying to determined if it's a JS or CSS problem at this point. Stay tuned.

Update: it's CSS, fixing

@perrygovier perrygovier self-assigned this Jul 1, 2014
@perrygovier
Copy link
Contributor

Actually, it looks like this is already fixed. Are you seeing this in the nightly?

@calendee
Copy link
Author

calendee commented Jul 1, 2014

Thanks for the quick response.

All good in the nightly : http://codepen.io/calendee/pen/tBnlJ

However, it would be nice if a card had just a slight bit of padding at the bottom by default so it wouldn't sit on the extreme edge of the view. Of course, it's not hard to do on my own but might be best if done be Ionic.

Feel free to close if you don't think that little bit is worth keep open for.

@thenovelnomad
Copy link

This is still an issue if the view has a sub-header, and the sub-header is currently hidden.
Check it out here and toggle the sub-header by clicking the button:
http://codepen.io/thenovelnomad/pen/vwbmx

@perrygovier
Copy link
Contributor

Hey @thenovelnomad, in this case, you'd want to use the has-header class.
http://codepen.io/perrygovier/pen/jLJAg

Hey @calendee, I added a little extra margin-bottom to the last .list.card on a page

Looks like this one is fixed.

@pulkitsinghal
Copy link

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 6, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs: reply the issue needs a response from the user
Projects
None yet
Development

No branches or pull requests

4 participants