Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behavior when both If-None-Match and If-Modified-Since headers provided #37

Open
mattmetlis opened this issue Sep 4, 2019 · 1 comment · May be fixed by #38
Open

Behavior when both If-None-Match and If-Modified-Since headers provided #37

mattmetlis opened this issue Sep 4, 2019 · 1 comment · May be fixed by #38

Comments

@mattmetlis
Copy link

The current behavior of the bundle when the client provides both If-None-Match and If-Modified-Since headers does not match the HTTP/1.1 spec. According to the spec, A recipient MUST ignore If-Modified-Since if the request contains an If-None-Match header field (https://tools.ietf.org/html/rfc7232#section-3.3). The current behavior of the bundle is to return a 304 if the check on either condition would on its own result in a 304.

For example, if the client specifies an eTag in the If-None-Match header that does not match the server's eTag for the entity, and the client specifies a time in the If-Modified-Since header that is later than the server's last modified time for the entity, the server will respond with a 304. It should instead respond with a 200 and the entity.

mattmetlis added a commit to mattmetlis/dropwizard-configurable-assets-bundle that referenced this issue Sep 4, 2019
…-Modified-Since when If-None-Match is also specified.
@mattmetlis
Copy link
Author

Are any maintainers watching this project?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant