NoopMetricRegistry.NoopTimer::time(Runnable) should actually run the supplied Runnable

[oxbowlakes]

The implementation of NoopMetricRegistry.NoopTimer's time method which takes a Callable<T> is as follows:

        @Override
        public <T> T time(Callable<T> event) throws Exception {
            return event.call();
        }

However the implementation of the method overload which takes a Runnable is:

        @Override
        public void time(Runnable event) {
            // NOP
        }

This latter implementation is incorrect as the Runnable represents important business logic. That is, switching implementations (e.g. during testing) to a NoopMetricRegistry actually effects the behaviour of the system!

The method body should be as follows:

        @Override
        public void time(Runnable event) {
            event.run();
        }

[joschi]

@oxbowlakes Thanks for reporting this!