-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hopefully add better timeouts and ordering to JDBCExtractionNamespaceTest #1658
Hopefully add better timeouts and ordering to JDBCExtractionNamespaceTest #1658
Conversation
ec50205
to
9a34c54
Compare
8117664
to
a063a72
Compare
a063a72
to
299c5bc
Compare
); | ||
committed.await(10, TimeUnit.SECONDS); | ||
Thread.sleep(2); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason for the sleep here, given that we wait just before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If latch completes within 1 ms it makes sure a few ms have elapsed. This is to help make sure things which only check on granularity of ms have a few ms spacing to acknowledge timestamp changes..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added comments
3c41b27
to
1555763
Compare
a767040
to
4582d65
Compare
7bdcbb7
to
24c835e
Compare
Failure in |
Failure in another test, restarting to see if I can get a JDBC test failure |
24c835e
to
cf2d3ee
Compare
failed on |
cf2d3ee
to
df69d94
Compare
df69d94
to
ac8e32b
Compare
This seems to be in a pretty good state overall. |
👍 |
1 similar comment
+1 |
Hopefully add better timeouts and ordering to JDBCExtractionNamespaceTest
I'll be opening and closing this a few times to see if I can get a failure case for
JDBCExtractionNamespaceTest