composing emitter module to use multiple emitters together #1699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himanshug
force-pushed
the
composing_emitter
branch
2 times, most recently
from
fccbb5d to
6e59fe0
Compare
|
@himanshug can we get this mergeable? |
|
@fjy this needs 0.3.2 release in metamx/emitter . |
|
@himanshug I just released emitter 0.3.2, should be on maven central in about 20min |
|
@xvrl thanks. |
himanshug
force-pushed
the
composing_emitter
branch
from
6e59fe0 to
4819d72
Compare
himanshug
force-pushed
the
composing_emitter
branch
from
4819d72 to
ebdb612
Compare
|
@drcrallen thanks for re-build. |
| @@ -125,7 +125,7 @@ The Druid servers emit various metrics and alerts via something we call an Emitt | |||
|
|
|||
| |Property|Description|Default| | |||
| |--------|-----------|-------| | |||
| |`druid.emitter`|Setting this value to "noop", "logging", or "http" will instantialize one of the emitter modules.|noop| | |||
| |`druid.emitter`|Setting this value to "noop", "logging", or "http" will instantialize one of the emitter modules. value "composing" can be used to instantialize multiple emitter modules. |noop| | |||
There was a problem hiding this comment.
Instantiate? Initialize?
Instantialize is not a word :)
There was a problem hiding this comment.
well... I also thought it was weird. Since the word "instantialize" was already used in the documentation (look at the deleted line), [being a non-native English speaker] I doubted myself and thought may be it was the correct word to use in this situation. :)
will send another PR to fix it.
|
👍 |
drcrallen
added a commit
that referenced
this pull request
Sep 10, 2015
composing emitter module to use multiple emitters together
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caution: this can only be merged after metamx/emitter#11 is merged and emiter version 0.3.2 is released.
This allows you to have multiple emitters configured at the same time. This can be useful if you want to have multiple potential landing points for your emitter messages.
For example we use this for sending druid metrics to another druid cluster via a "http" emitter and to a hosted monitoring system via another custom emitter..