Allow SegmentAnalyzer to read columns from StorageAdapter, allow SegmentMetadataQuery to query IncrementalIndexSegments on realtime node #1739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| columns.put( | ||
| Column.TIME_COLUMN_NAME, | ||
| new ColumnAnalysis(ValueType.LONG.name(), 0, null, null) | ||
| ); |
There was a problem hiding this comment.
This could be a single line // comment, also imo the real issue is that StorageAdapters don't tell you how many rows they have. (you don't actually need to read the time column to know how big it is; you just have to know how many rows the segment has)
There was a problem hiding this comment.
@gianm For the metrics columns, I can get the row count via IncrementalIndex.size() or QueryableIndex.getNumRows(). I don't think this covers size calculations for the string or complex columns though.
There was a problem hiding this comment.
@gianm Updated patch, analysis on StorageAdapter can now do size calculation for time and metrics columns
jon-wei
force-pushed
the
segment_realtime
branch
2 times, most recently
from
a6fc236 to
934a052
Compare
…entMetadataQuery to query IncrementalIndexSegments on realtime node
jon-wei
force-pushed
the
segment_realtime
branch
from
934a052 to
367c50d
Compare
|
👍 |
gianm
added a commit
that referenced
this pull request
Sep 18, 2015
Allow SegmentAnalyzer to read columns from StorageAdapter, allow SegmentMetadataQuery to query IncrementalIndexSegments on realtime node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows SegmentAnalyzer to create an analysis from a StorageAdapter; this is used during the SegmentMetadataQuery to allow the query to read from IncrementalIndexSegments wrapped by a StorageAdapter.
This allows the metadata query to read columns from the most recent hydrant on the realtime node.
Size calculation is not performed in this alternate path.