Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Module Name to CertificateDsc #114

Closed
PlagueHO opened this issue Dec 8, 2017 · 11 comments
Closed

Convert Module Name to CertificateDsc #114

PlagueHO opened this issue Dec 8, 2017 · 11 comments
Labels
breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request. in progress The issue is being actively worked on by someone.
Milestone
HQRM

Comments

@PlagueHO
Copy link
Member

PlagueHO commented Dec 8, 2017

As per recent DSC Resource Naming guidelines changes:
https://github.com/PowerShell/DscResources/blob/master/Naming.md
@PlagueHO PlagueHO added breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. labels Dec 8, 2017
@PlagueHO PlagueHO added this to the HQRM milestone Dec 8, 2017
@timhaintz
Copy link
Contributor

Sign me up. Thanks. :octocat:

@PlagueHO PlagueHO added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Jan 28, 2018
@PlagueHO PlagueHO assigned PlagueHO and unassigned PlagueHO Jan 28, 2018
@PlagueHO
Copy link
Member Author

All yours! Thanks @timhaintz !

@PlagueHO
Copy link
Member Author

PlagueHO commented Jan 28, 2018 •
edited
Loading

Maybe do this one second, because I wan't to try and get a couple of the open PR's for this one (#119, #117, #108) through first. I'll try and get these moving again this weekend. I'm going to do the review for #119 tonight.

@timhaintz
Copy link
Contributor

Morning @PlagueHO yell out (bump) when you get all of your PR's done and I can have a look at this one too. Thanks.

@PlagueHO
Copy link
Member Author

Thanks @timhaintz - I'll give the other submitters a couple of days and if nothing happens we'll just move forward with the rename.

@timhaintz
Copy link
Contributor

@PlagueHO I noticed #119 got merged. Did you want me to wait for the others? If it messes up the process me going ahead, happy to wait. Up to you. Thanks.

@PlagueHO
Copy link
Member Author

PlagueHO commented Mar 1, 2018

Hi @timhaintz - it looks like the other PR's aren't going to go through anytime soon, so maybe just go ahead and do this one. 😁

I'm not sure when @kwirkykat will get a chance to do the repo rename though, so no rush! Thanks again for helping out (I've had almost no time at all lately to do anything DSC - too busy with day job 😢)

@timhaintz
Copy link
Contributor

No worries @PlagueHO will get onto it this weekend.
I saw you released the updated Cosmos DB Module. Nice! You have been busy. :D
Thanks for your help with all of this. Great way to learn the eco system.

@PlagueHO
Copy link
Member Author

PlagueHO commented Mar 2, 2018

Thanks again for all your help @timhaintz ! Nice to see attention on the CosmosDB module! 😁 I'm at the MVP summit in US all this week so might get a bit of "non-work" time to catch up on DSC stuff (hopefully).

@timhaintz
Copy link
Contributor

Question about $script:ModulesToTest in the file ModuleConflict.Tests.ps1, it refers to the xDFS module. I've just renamed that one to DFSDsc but it hasn't been merged with master yet. Do you want me to update them to what they will be or keep them as they currently are? Thanks @PlagueHO . Have a great time at the MVP summit. Would love to go one day. :)

@PlagueHO
Copy link
Member Author

Completed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request. in progress The issue is being actively worked on by someone.
Projects
None yet
Milestone
HQRM
Development

No branches or pull requests
2 participants
@PlagueHO @timhaintz