Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSFT_xGroupResource: Fix PSSA Issues #130

Closed
kwirkykat opened this issue May 17, 2016 · 1 comment · Fixed by #240
Closed

MSFT_xGroupResource: Fix PSSA Issues #130

kwirkykat opened this issue May 17, 2016 · 1 comment · Fixed by #240
Assignees
@kwirkykat
Labels
enhancement The issue is an enhancement request.

Comments

@kwirkykat
Copy link
Contributor

The PowerShell Script Analyzer issues in MSFT_xGroupResource need to be fixed.
This is the current result of running Invoke-ScriptAnalyzer:
image
image
@kwirkykat kwirkykat self-assigned this Jun 17, 2016
@kwirkykat
Copy link
Contributor Author

This is part of #160

@kwirkykat kwirkykat added the enhancement The issue is an enhancement request. label Aug 18, 2016
Dan1el42 pushed a commit to Dan1el42/xPSDesiredStateConfiguration that referenced this issue Sep 17, 2016
Update xGroupResource
3258ead 
- Updates to resolve the reported PSSA issues
- Formatting updated as per style guidelines
- Comment-based help added to Get-/Set-/Test-TargetResource functions
- Typos fixed in Unit test script
- Unit test 'Get-TargetResource/Should return hashtable with correct values when group has no members' updated to handle the expected empty Members array correctly

Fixes dsccommunity#130
@Dan1el42 Dan1el42 mentioned this issue Sep 17, 2016
Merged
Dan1el42 pushed a commit to Dan1el42/xPSDesiredStateConfiguration that referenced this issue Sep 21, 2016
Update xGroupResource
27424ae 
- Updates to resolve the reported PSSA issues
- Formatting updated as per style guidelines
- Comment-based help added to Get-/Set-/Test-TargetResource functions
- Typos fixed in Unit test script
- Unit test 'Get-TargetResource/Should return hashtable with correct values when group has no members' updated to handle the expected empty Members array correctly

Fixes dsccommunity#130
Dan1el42 pushed a commit to Dan1el42/xPSDesiredStateConfiguration that referenced this issue Sep 22, 2016
Update xGroupResource
35e8b07 
- Updates to resolve the reported PSSA issues
- Formatting updated as per style guidelines
- Comment-based help added to Get-/Set-/Test-TargetResource functions
- Typos fixed in Unit test script
- Unit test 'Get-TargetResource/Should return hashtable with correct values when group has no members' updated to handle the expected empty Members array correctly

Fixes dsccommunity#130
Dan1el42 pushed a commit to Dan1el42/xPSDesiredStateConfiguration that referenced this issue Sep 25, 2016
Update xGroupResource
3d7c474 
- Updates to resolve the reported PSSA issues
- Formatting updated as per style guidelines
- Comment-based help added to Get-/Set-/Test-TargetResource functions
- Typos fixed in Unit test script
- Unit test 'Get-TargetResource/Should return hashtable with correct values when group has no members' updated to handle the expected empty Members array correctly

Fixes dsccommunity#130
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kwirkykat kwirkykat

Labels
enhancement The issue is an enhancement request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update xGroupResource to high quality resource Dan1el42/xPSDesiredStateConfiguration
1 participant
@kwirkykat