Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving the Environment Resource to Open-Source xEnvironment #147

Merged
merged 11 commits into from
Jun 8, 2016

Conversation

kwirkykat
Copy link
Contributor

@kwirkykat kwirkykat commented Jun 7, 2016

xEnvironment is an open-source copy of the in-box Environment resource.
Tests and an example have been added.


This change is Reviewable

@kwirkykat kwirkykat changed the title Moving the Environment Resource to Open-Source xEnvironemnt Moving the Environment Resource to Open-Source xEnvironment Jun 7, 2016
@kwirkykat
Copy link
Contributor Author

Remaining test failure is due to PSSA errors in existing resources.
#129 and #131 are already filed to address these issues.

@PlagueHO
Copy link
Member

PlagueHO commented Jun 8, 2016

@kwirkykat - I fixed all the PSSA errors with PR #123. So once that is merged you should be able to trigger a dummy commit on this PR to resolve the AppVeyor failure.

@vors
Copy link
Contributor

vors commented Jun 8, 2016

@PlagueHO @kwirkykat should be able to trigger re-build without dummy commit, directly from appveyor.
image

I tried to figure out how to enable it for non-powershell org members, but AppVeyor doesn't support it out-of-the-box http://help.appveyor.com/discussions/questions/2288-how-i-can-allow-anybody-trigger-a-re-build-on-a-public-project

@PlagueHO
Copy link
Member

PlagueHO commented Jun 8, 2016

@vors - no worries 😄 I'm OK with doing dummy commits every now and then. I forgot @kwirkykat could issue them directly.

@kwirkykat kwirkykat merged commit 90f5c7d into dsccommunity:dev Jun 8, 2016
@kwirkykat kwirkykat deleted the AddEnvironmentResource branch June 8, 2016 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants