Merging In-Box Archive Resource with xArchive #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge is part of #160.
Unfortunately, the in-box Archive resource has been completely overhauled since it was originally posted on GitHub, so this is a very large change. It doesn't look like the community made many changes to xArchive since then, but the few changes that were made have been transferred to the merged resource.
The in-box Archive also was not passing its own tests, so I fixed the resource so that the tests now pass.
The new, updated xArchive will now properly remove an unpacked zip file when Ensure is set to 'Absent'.
This change is