Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging In-Box Package Resource with xPackage #176

Merged
merged 16 commits into from
Jul 13, 2016

Conversation

kwirkykat
Copy link
Contributor

@kwirkykat kwirkykat commented Jul 11, 2016

This merge is part of #160.

The in-box Package resource has been changed a lot since it was originally posted on GitHub, including a change to the schema of the resource. There were also quite a few changes from the community, most of which have been retained.

There is an HTTPS test added which is currently getting skipped. It seems to have problems with the local SSL connection. The test did not work with the original community resource either. Skipping it for now so the resource can get the needed updates and tests.


This change is Reviewable

@kwirkykat
Copy link
Contributor Author

The new Package tests have added 50 MINUTES to the overall xPSDesiredStateConfiguration tests. 👎 This is ridiculous. Looking at the cause of the crazy time delay now to see if anything can be done about it.

@kwirkykat
Copy link
Contributor Author

Test time reduced back down to around 5 minutes. 👍

@kwirkykat kwirkykat merged commit a1b69ca into dsccommunity:dev Jul 13, 2016
@kwirkykat kwirkykat deleted the MergePackageResource branch July 13, 2016 23:25
@brantb
Copy link

brantb commented Jul 20, 2016

@kwirkykat I noticed that the ability to test the installation status using a registry key (using the InstalledCheckReg* properties) didn't survive the merge. Are there plans to restore it at some point or is that still up in the air?

@iainbrighton
Copy link
Contributor

@kwirkykat @brantb DOH! We use that feature extensively as developers do some wacky stuff with their packages. Any idea why it was dropped and can this be added back in?

@kwirkykat
Copy link
Contributor Author

@iainbrighton @brantb These parameters are no longer in the in-box Package resource. I'm not really sure why. I can add them back into xPackage if you guys would like.

Can you guys post some tests/scripts that should work with these parameters added back in?

@kwirkykat
Copy link
Contributor Author

@iainbrighton @brantb Can one of you guys please submit an issue for this if you would like the params added back in?

@iainbrighton
Copy link
Contributor

@kwirkykat @brantb Done (#187) 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants