Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed PSSA issues in xPackageResource - Fixes #131 #196

Merged
merged 4 commits into from
Aug 17, 2016
Merged

Fixed PSSA issues in xPackageResource - Fixes #131 #196

merged 4 commits into from
Aug 17, 2016

Conversation

PlagueHO
Copy link
Member

@PlagueHO PlagueHO commented Aug 15, 2016

This change is Reviewable

@kwirkykat
Copy link
Contributor

@PlagueHO Tests are failing because some merge artifacts were accidentally left in

@kwirkykat kwirkykat added the waiting for author response The pull request is waiting for the author to respond to comments in the pull request. label Aug 15, 2016
@kwirkykat kwirkykat self-assigned this Aug 15, 2016
@PlagueHO
Copy link
Member Author

Sorry @kwirkykat - what a noob 😄 All fixed. Fixed the bad unit test as well.

@kwirkykat kwirkykat removed the waiting for author response The pull request is waiting for the author to respond to comments in the pull request. label Aug 16, 2016
@kwirkykat
Copy link
Contributor

:lgtm:


Reviewed 1 of 2 files at r2, 2 of 2 files at r3.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


README.md, line 357 [r3] (raw file):

    * Updated xService resource to allow empty string for Description parameter.
* Merged xProcess with in-box Process resource and added tests.
* Fixed PSSA issues in xPackageResource.

This should be moved up to the Unreleased section


Comments from Reviewable

@kwirkykat kwirkykat merged commit 699e146 into dsccommunity:dev Aug 17, 2016
@PlagueHO PlagueHO deleted the Fix-131/MSFT_xPackageResource-Fix-PSSA-Issues branch August 18, 2016 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants