Update xProcess resource to fix PSSA and style Issues

[Dan1el42]

Hello everyone,

Another PR to fix #132 PSSA and style issues. Please review at your earliest convenience.

Thanks very much,
Daniel

[Dan1el42]

Script Analyzer:

• Before
  
• After
  

[kwirkykat]

Reviewed 1 of 2 files at r1.
Review status: 0 of 2 files reviewed at latest revision, 13 unresolved discussions.

---

DSCResources/MSFT_xProcessResource/MSFT_xProcessResource.psm1, line 140 [r1] (raw file):

If this the
If this is the

---

DSCResources/MSFT_xProcessResource/MSFT_xProcessResource.psm1, line 224 [r1] (raw file):

If this the
If this is the

---

DSCResources/MSFT_xProcessResource/MSFT_xProcessResource.psm1, line 296 [r1] (raw file):

    if ($null -ne $PsDscContext.RunAsUser)
    {
        $params = @{

$params should have a more descriptive name. (ex: $exceptionParams, $invalidArgParams, $newInvalidArgumentExceptionParams)

---

DSCResources/MSFT_xProcessResource/MSFT_xProcessResource.psm1, line 320 [r1] (raw file):

    if ($Ensure -eq 'Absent')
    {
        $params = @{

$params should have a more descriptive name. (ex: $assertHashtableParams, $assertArgsParams)

---

DSCResources/MSFT_xProcessResource/MSFT_xProcessResource.psm1, line 373 [r1] (raw file):

            if (-not [String]::IsNullOrEmpty($PSBoundParameters[$shouldBeRootedPathArgument]))
            {
                $params = @{

$params needs a more descriptive name

---

DSCResources/MSFT_xProcessResource/MSFT_xProcessResource.psm1, line 387 [r1] (raw file):

            if (-not [String]::IsNullOrEmpty($PSBoundParameters[$shouldExistPathArgument]))
            {
                $params = @{

$params needs a more descriptive name

---

DSCResources/MSFT_xProcessResource/MSFT_xProcessResource.psm1, line 412 [r1] (raw file):

            {
                $parameterKey = $startProcessOptionalArgumentMap[$startProcessOptionalArgumentName]
                $value = $PSBoundParameters[$parameterKey]

$value needs a more descriptive name (ex: $parameterValue, $startProcessArugmentValue, etc...)

---

DSCResources/MSFT_xProcessResource/MSFT_xProcessResource.psm1, line 440 [r1] (raw file):

                    foreach ($key in @('StandardOutputPath','StandardInputPath','WorkingDirectory'))
                    {
                        $params = {

$params needs a more descriptive name

---

DSCResources/MSFT_xProcessResource/MSFT_xProcessResource.psm1, line 507 [r1] (raw file):

If this the
If this is the

---

DSCResources/MSFT_xProcessResource/MSFT_xProcessResource.psm1, line 521 [r1] (raw file):

Set this property to "Present" to ensure that the process
exists. Otherwise, set it to "Absent".

Set this property to "Present" to return true if the process exisits.
Otherwise, set it to "Absent" to return true if the process does not exist.

Test-TargetResource will not change the state of the process.

---

DSCResources/MSFT_xProcessResource/MSFT_xProcessResource.psm1, line 524 [r1] (raw file):

        exists. Otherwise, set it to "Absent". The default is "Present".

    .PARAMETER StandardOutputPath

Only the Path, Arguments, Credential, and Ensure parameters are actually used for this function.
Can you please change the descriptions of the other parameters accordingly?

---

DSCResources/MSFT_xProcessResource/MSFT_xProcessResource.psm1, line 580 [r1] (raw file):

    if ($null -ne $PsDscContext.RunAsUser)
    {
        $params = @{

$params needs a more descriptive name

---

DSCResources/MSFT_xProcessResource/MSFT_xProcessResource.psm1, line 748 [r1] (raw file):

            {
                Write-Verbose -Message ($LocalizedData.VerboseInProcessHandle -f $process.Id)
                $params = @{

$params needs a more descriptive name

---

Comments from Reviewable

[Dan1el42]

@kwirkykat , thanks so much for your thorough review on a Sunday 👍 . I've pushed a new commit to my branch which should fix everything you've highlighted with your comments.

[kwirkykat]

---

Reviewed 2 of 2 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable