Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary warning when donating to GBs - FP packs in stock #1114

Closed
Arklur opened this issue May 28, 2020 · 4 comments
Closed

Unnecessary warning when donating to GBs - FP packs in stock #1114

Arklur opened this issue May 28, 2020 · 4 comments
Labels
Bug Duplicate This issue or pull request already exists Next Version Issue will be dealt with in the next update

Comments

@Arklur
Copy link
Contributor

Arklur commented May 28, 2020

Probably this came in the last update, but I don't feel the need of it / would like to turn this off.

Since 99,9999% of the time obviously I won't have enough FPs to "snipe", the numbers being in red are misleading to me, and as I see, there is no option to disable it. In my opinion the previous version was much better, could you revert this change or add an option to disable this "conditional formatting"?

@Arklur Arklur closed this as completed May 28, 2020
@Gindi4711 Gindi4711 reopened this May 28, 2020
@Gindi4711 Gindi4711 added Duplicate This issue or pull request already exists Bug Next Version Issue will be dealt with in the next update labels May 28, 2020
@mainIine
Copy link
Owner

Duplicate of #1089

@mainIine mainIine marked this as a duplicate of #1089 May 28, 2020
@Gindi4711
Copy link
Collaborator

This is caused by a change on Inno side how to handle FP storage, so there is no way to revert back.
We will have a fix for the new logic in the next update.

@Arklur
Copy link
Contributor Author

Arklur commented May 28, 2020

Yeah, I've realized I totally misunderstood what's the warning about, or well, didn't notice the "FP stock" dropped to 0, then I noticed the issue is already reported and pinned, that's why I closed this one.

+1: seems like it was always worked like that (no change on your side and no need to revert anything), I just haven't seen this since I always had enough FPs...sorry for the misleading report, next time I'll try to be more cautious.

@mainIine
Copy link
Owner

Its ok ;-)

mainIine pushed a commit that referenced this issue May 29, 2020
#1100 #1101 #1108 #1114 #1116 #1117

- Infobox FP Berechnung gefixt / Fixed FP calculation #555 #742 #771 #939 #1080
- Erntehelfer / Harvest helper Fix #1036 #1110 #1058
- Statistic army fix #1077
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Duplicate This issue or pull request already exists Next Version Issue will be dealt with in the next update
Projects
None yet
Development

No branches or pull requests

3 participants