Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Level-up message (in the Infobox) has an incorrect FP amount #771

Closed
scibuff opened this issue Apr 8, 2020 · 3 comments
Closed

Level-up message (in the Infobox) has an incorrect FP amount #771

scibuff opened this issue Apr 8, 2020 · 3 comments
Labels
Bug Duplicate This issue or pull request already exists Next Version Issue will be dealt with in the next update

Comments

@scibuff
Copy link
Contributor

scibuff commented Apr 8, 2020

The calculation for returned/gained forge points is incorrect. The message says 0 FPs have been returned.

image

console error:

_main.js?v=2.4.4:379 TypeError: Cannot read property 'find' of null
    at Object.NoticeIndicatorService_getPlayerNoticeIndicators (infoboard.js?v=2.4.4:347)
    at Object.BoxContent (infoboard.js?v=2.4.4:185)
    at infoboard.js?v=2.4.4:58
    at WebSocket.wsMessageHandler (_main.js?v=2.4.4:377)
wsMessageHandler @ _main.js?v=2.4.4:379

This is related to #762

Window 10
Chrome/80.0.3987.163
en9 (Jaims)
2.4.4 - English
@scibuff scibuff changed the title Level-up message (in the Infobox) has an incorrect returned FP calculation Level-up message (in the Infobox) has an incorrect FP amount Apr 8, 2020
@syjytg
Copy link

syjytg commented Apr 9, 2020

How do you get the info box to fill? Mine is always empty.

@Gindi4711 Gindi4711 added the Bug label Apr 9, 2020
@scibuff
Copy link
Contributor Author

scibuff commented Apr 9, 2020

How do you get the info box to fill? Mine is always empty.

The infobox is always empty when you open it. You need to wait until events in the game happen ...

@Gindi4711 Gindi4711 added the Duplicate This issue or pull request already exists label Apr 10, 2020
@scibuff
Copy link
Contributor Author

scibuff commented May 27, 2020

This is now fixed on Beta (#1107) and will be in the next release

@scibuff scibuff closed this as completed May 27, 2020
@Gindi4711 Gindi4711 added the Next Version Issue will be dealt with in the next update label May 27, 2020
@Gindi4711 Gindi4711 reopened this May 27, 2020
mainIine pushed a commit that referenced this issue May 29, 2020
- FP Lager / Stock fixed #836 #1025 #1044 #1059 #1075 #1089 #1097 #1098
abe625a 
#1100 #1101 #1108 #1114 #1116 #1117

- Infobox FP Berechnung gefixt / Fixed FP calculation #555 #742 #771 #939 #1080
- Erntehelfer / Harvest helper Fix #1036 #1110 #1058
- Statistic army fix #1077
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Duplicate This issue or pull request already exists Next Version Issue will be dealt with in the next update
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@scibuff @mainIine @syjytg @Gindi4711