Enhance Notification with Channels. #226

xellos00 · 2022-08-11T02:29:43Z

Parents: Enhancement on Dispatchers(Notifications. Prev) #240

Checklist

New Feature for the Service/Plugin (Vatz)
Enhancement (Vatz)
others(etc. e.g, documentation, project policy management)

Is your feature request related to a problem? Please describe.

A clear and concise description of what the problem is. such as Ex. I'm always frustrated

I'm always frustrated we didn't deal with our notification through channels

I want this to dispatcher send a notification only registered channels that is defined in default.yaml

Describe the solution you'd like| Ex

A clear and concise description of what you want to happen

Let's set up a notification channels as below

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you have considered.

Additional context or comment

Add any other context or screenshots about the feature request here.

xellos00 · 2022-08-11T02:40:57Z

@Choi-Jinhong
Can you understand issue above?
once #224 has finished and closed, I want you to start this issue.

gnongs · 2022-08-17T01:29:08Z

I would like to change the yaml file as below.
@xellos00 Could you give me your opinion?

vatz_protocol_info:
  protocol_identifier: "VATZ"
  port: 9090
  notification_info:
    host_name: "put your host name here"
    dispatch_channels:
      - channel: "discord"
        secret: "Your secert"
      - channel: "pagerduty"
        secret: "Your secret"
  health_checker_schedule:
    - "0 1 * * *"
plugins_infos:
  default_verify_interval: 15
  default_execute_interval: 30
  default_plugin_name: "vatz-plugin"
  plugins:
    - plugin_name: "sample1"
      plugin_address: "localhost"
      plugin_port: 9091
      executable_methods:
        - method_name: "sampleMethod1"
    - plugin_name: "sample2"
      plugin_address: "localhost"
      verify_interval: 7
      execute_interval: 9
      plugin_port: 10002
      executable_methods:
        - method_name: "sampleMethod2"

xellos00 · 2022-08-17T02:00:20Z

I would like to change the yaml file as below.

@xellos00 Could you give me your opinion?

vatz_protocol_info:

  protocol_identifier: "VATZ"

  port: 9090

  notification_info:

    dispatch_channels:

      - channel: "discord"

        secret: "Your secert"

      - channel: "pagerduty"

        secret: "Your secret"

  health_checker_schedule:

    - "0 1 * * *"

plugins_infos:

  default_verify_interval: 15

  default_execute_interval: 30

  default_plugin_name: "vatz-plugin"

  plugins:

    - plugin_name: "sample1"

      plugin_address: "localhost"

      plugin_port: 9091

      executable_methods:

        - method_name: "sampleMethod1"

    - plugin_name: "sample2"

      plugin_address: "localhost"

      verify_interval: 7

      execute_interval: 9

      plugin_port: 10002

      executable_methods:

        - method_name: "sampleMethod2"

better than my sample😎 btw Please, add host_name as well.

gnongs · 2022-08-17T02:26:42Z

I would like to change the yaml file as below.
@xellos00 Could you give me your opinion?

vatz_protocol_info:

  protocol_identifier: "VATZ"

  port: 9090

  notification_info:

    dispatch_channels:

      - channel: "discord"

        secret: "Your secert"

      - channel: "pagerduty"

        secret: "Your secret"

  health_checker_schedule:

    - "0 1 * * *"

plugins_infos:

  default_verify_interval: 15

  default_execute_interval: 30

  default_plugin_name: "vatz-plugin"

  plugins:

    - plugin_name: "sample1"

      plugin_address: "localhost"

      plugin_port: 9091

      executable_methods:

        - method_name: "sampleMethod1"

    - plugin_name: "sample2"

      plugin_address: "localhost"

      verify_interval: 7

      execute_interval: 9

      plugin_port: 10002

      executable_methods:

        - method_name: "sampleMethod2"

better than my sample😎 btw Please, add host_name as well.

How about channel_type ?

xellos00 · 2022-08-17T02:29:20Z

@Choi-Jinhong
I mean host_name for notification to recognize which machine has sent notification.
what's channel_type for?

gnongs · 2022-08-17T02:41:05Z

I mean host_name for notification to recognize which machine has sent notification.

Sorry. I misunderstand. I thought channel-typewould be clearer thanchannel, so I said it would be better to change it to channel-type`.

Could I change it as below?

vatz_protocol_info:
  protocol_identifier: "VATZ"
  port: 9090
  notification_info:
    host_name: "Your machine name"
    dispatch_channels:
      - channel_type: "discord"
        secret: "Your secert"
      - channel_type: "pagerduty"
        secret: "Your secret"
  health_checker_schedule:
    - "0 1 * * *"
plugins_infos:
  default_verify_interval: 15
  default_execute_interval: 30
  default_plugin_name: "vatz-plugin"
  plugins:
    - plugin_name: "sample1"
      plugin_address: "localhost"
      plugin_port: 9091
      executable_methods:
        - method_name: "sampleMethod1"
    - plugin_name: "sample2"
      plugin_address: "localhost"
      verify_interval: 7
      execute_interval: 9
      plugin_port: 10002
      executable_methods:
        - method_name: "sampleMethod2"

xellos00 · 2022-08-17T03:05:59Z

I mean host_name for notification to recognize which machine has sent notification.

Sorry. I misunderstand. I thought channel-typewould be clearer thanchannel, so I said it would be better to change it to channel-type`.

Could I change it as below?

vatz_protocol_info:
  protocol_identifier: "VATZ"
  port: 9090
  notification_info:
    host_name: "Your machine name"
    dispatch_channels:
      - channel_type: "discord"
        secret: "Your secert"
      - channel_type: "pagerduty"
        secret: "Your secret"
  health_checker_schedule:
    - "0 1 * * *"
plugins_infos:
  default_verify_interval: 15
  default_execute_interval: 30
  default_plugin_name: "vatz-plugin"
  plugins:
    - plugin_name: "sample1"
      plugin_address: "localhost"
      plugin_port: 9091
      executable_methods:
        - method_name: "sampleMethod1"
    - plugin_name: "sample2"
      plugin_address: "localhost"
      verify_interval: 7
      execute_interval: 9
      plugin_port: 10002
      executable_methods:
        - method_name: "sampleMethod2"

I prefer channel than channel_type for me.
you can add and find out for everyone to review because It doesn't matter that much, I guess.

gnongs · 2022-08-17T03:08:07Z

I mean host_name for notification to recognize which machine has sent notification.

Sorry. I misunderstand. I thought channel-typewould be clearer thanchannel, so I said it would be better to change it to channel-type`.
Could I change it as below?

vatz_protocol_info:
  protocol_identifier: "VATZ"
  port: 9090
  notification_info:
    host_name: "Your machine name"
    dispatch_channels:
      - channel_type: "discord"
        secret: "Your secert"
      - channel_type: "pagerduty"
        secret: "Your secret"
  health_checker_schedule:
    - "0 1 * * *"
plugins_infos:
  default_verify_interval: 15
  default_execute_interval: 30
  default_plugin_name: "vatz-plugin"
  plugins:
    - plugin_name: "sample1"
      plugin_address: "localhost"
      plugin_port: 9091
      executable_methods:
        - method_name: "sampleMethod1"
    - plugin_name: "sample2"
      plugin_address: "localhost"
      verify_interval: 7
      execute_interval: 9
      plugin_port: 10002
      executable_methods:
        - method_name: "sampleMethod2"

I prefer channel than channel_type for me. you can add and find out for everyone to review because It doesn't matter that much, I guess.

Then I think we can just proceed with channel :D

gnongs · 2022-08-23T08:34:19Z

TODOs

Make a new channel type.
Edit dispatcher that can read multi-channel on default.yaml.
When ./vatz init, modify the contents of the file that appears at this time.

@xellos00 Could I ask you questions?

What do I develop channel first? telegram? pagerduty?
Is the resource_type the variable that checks the criteria of the channel to be sent in the message?

xellos00 · 2022-08-23T17:31:33Z

resource_type

I am going to resolve issue for PR #235, It would contain sample code for telegram, You can start from that point.
I mainly put resource_type as plugin identifier previously if you have somewhat idea to deal with resource_type, let me know. Thanks

gnongs · 2022-08-24T01:17:17Z

I mainly put resource_type as plugin identifier previously if you have somewhat idea to deal with resource_type, let me know. Thanks

@xellos00 If resource type is a variable containing information about the plug-in, I think we need a new variable for channel.

xellos00 · 2022-08-29T01:53:58Z

@Choi-Jinhong
I still don't get your point, what do we need for new variable for channel?
Let me know if there's further point that we need discuss.

gnongs · 2022-08-30T23:07:42Z

@Choi-Jinhong

I still don't get your point, what do we need for new variable for channel?

Let me know if there's further point that we need discuss.

I think I got confused with the way that send messages.

xellos00 · 2022-08-31T18:03:39Z

@Choi-Jinhong
I will create a issue to Notification Enhancement as good first issue to deal child issues.

xellos00 · 2022-09-16T20:05:54Z

@gnongs
I think you don't need to worry about sync with compatibility with previous version for config.
Let's let them update it all together, let them update and re-run their plugins with vatz, until we settle proper way to do it.

gnongs · 2022-09-17T02:35:24Z

@gnongs I think you don't need to worry about sync with compatibility with previous version for config. Let's let them update it all together, let them update and re-run their plugins with vatz, until we settle proper way to do it.

@xellos00
First, I will develop it so that it can be used in parallel with the previous method.

xellos00 · 2022-09-28T08:53:02Z

I think you need to have following TODOs

1. Config update

notification_info: [
{ channel: telegram,  secret: `...` , chatId: `...` },
{ channel: discord,   secret: `...` },
]

1. GetDispatchers
- secret 을 포함한다.
- config를 읽어와서, 선언되 있는 dispatcher만 등록한다.

xellos00 added Vatz Project Name type:feature-development Any development regarding Vatz service/plugin, etc. labels Aug 11, 2022

xellos00 assigned gnongs Aug 11, 2022

xellos00 added area:svc Anything related to Vatz Service. type:enhancement Any enhancement for feature or anything labels Aug 11, 2022

xellos00 added this to the Sprint 15 ( ~ 2022-08-17) milestone Aug 11, 2022

xellos00 self-assigned this Aug 11, 2022

xellos00 mentioned this issue Aug 20, 2022

Apply factory pattern for every module #235

Merged

4 tasks

xellos00 modified the milestones: Sprint 15 ( ~ 2022-08-17), Sprint 16 ( ~ 2022-08-31) Aug 30, 2022

xellos00 modified the milestones: Sprint 16 ( ~ 2022-08-31), Sprint 17 ( ~ 2022-09-14) Aug 31, 2022

xellos00 mentioned this issue Aug 31, 2022

Enhancement on Dispatchers(Notifications. Prev) #240

Closed

3 tasks

xellos00 modified the milestones: Sprint 17 ( ~ 2022-09-14), Sprint 18 ( ~ 2022-09-28) Sep 15, 2022

gnongs mentioned this issue Sep 28, 2022

Dispatcher enhancement for configs, getDispatchers #253

Merged

4 tasks

xellos00 modified the milestones: Sprint 18 ( ~ 2022-09-28), Sprint 19 ( ~ 2022-10-12) Sep 29, 2022

xellos00 closed this as completed Oct 8, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enhance Notification with Channels. #226

Enhance Notification with Channels. #226

xellos00 commented Aug 11, 2022 •

edited

Loading

xellos00 commented Aug 11, 2022 •

edited

Loading

gnongs commented Aug 17, 2022 •

edited by xellos00

Loading

xellos00 commented Aug 17, 2022 •

edited

Loading

gnongs commented Aug 17, 2022

xellos00 commented Aug 17, 2022

gnongs commented Aug 17, 2022 •

edited

Loading

xellos00 commented Aug 17, 2022 •

edited

Loading

gnongs commented Aug 17, 2022

gnongs commented Aug 23, 2022 •

edited

Loading

xellos00 commented Aug 23, 2022

gnongs commented Aug 24, 2022 •

edited

Loading

xellos00 commented Aug 29, 2022 •

edited

Loading

gnongs commented Aug 30, 2022

xellos00 commented Aug 31, 2022

xellos00 commented Sep 16, 2022

gnongs commented Sep 17, 2022

xellos00 commented Sep 28, 2022

Enhance Notification with Channels. #226

Enhance Notification with Channels. #226

Comments

xellos00 commented Aug 11, 2022 • edited Loading

Checklist

Is your feature request related to a problem? Please describe.

Describe the solution you'd like| Ex

Describe alternatives you've considered

Additional context or comment

xellos00 commented Aug 11, 2022 • edited Loading

gnongs commented Aug 17, 2022 • edited by xellos00 Loading

xellos00 commented Aug 17, 2022 • edited Loading

gnongs commented Aug 17, 2022

xellos00 commented Aug 17, 2022

gnongs commented Aug 17, 2022 • edited Loading

xellos00 commented Aug 17, 2022 • edited Loading

gnongs commented Aug 17, 2022

gnongs commented Aug 23, 2022 • edited Loading

TODOs

xellos00 commented Aug 23, 2022

gnongs commented Aug 24, 2022 • edited Loading

xellos00 commented Aug 29, 2022 • edited Loading

gnongs commented Aug 30, 2022

xellos00 commented Aug 31, 2022

xellos00 commented Sep 16, 2022

gnongs commented Sep 17, 2022

xellos00 commented Sep 28, 2022

xellos00 commented Aug 11, 2022 •

edited

Loading

xellos00 commented Aug 11, 2022 •

edited

Loading

gnongs commented Aug 17, 2022 •

edited by xellos00

Loading

xellos00 commented Aug 17, 2022 •

edited

Loading

gnongs commented Aug 17, 2022 •

edited

Loading

xellos00 commented Aug 17, 2022 •

edited

Loading

gnongs commented Aug 23, 2022 •

edited

Loading

gnongs commented Aug 24, 2022 •

edited

Loading

xellos00 commented Aug 29, 2022 •

edited

Loading