Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle duplicated plugin install #321

Closed
Tracked by #316
rootwarp opened this issue Dec 2, 2022 · 2 comments
Closed
Tracked by #316

Handle duplicated plugin install #321

rootwarp opened this issue Dec 2, 2022 · 2 comments
Assignees
Labels
area:svc Anything related to Vatz Service. type:enhancement Any enhancement for feature or anything Vatz Project Name

Comments

@rootwarp
Copy link
Member

rootwarp commented Dec 2, 2022


Show error message if the user try to install the plugin that is already installed.

Ref. #317 (comment)

@rootwarp rootwarp mentioned this issue Dec 2, 2022
16 tasks
@rootwarp rootwarp added Vatz Project Name area:svc Anything related to Vatz Service. type:enhancement Any enhancement for feature or anything labels Dec 2, 2022
@xellos00 xellos00 self-assigned this May 9, 2023
@xellos00 xellos00 added this to the Sprint 33 ( ~ 2023-05-10) milestone May 9, 2023
@xellos00
Copy link
Member

xellos00 commented May 10, 2023

@rootwarp
Back in our past discussion, we tried to use plugin_id due to its name duplication in different versions and then I thought it's a good idea to create a new primary flag which was plugin_id.

I've tried a new identifier which was plugin_id to prevent the installation of a duplicate plugin while I was developing PR #428 but decided to remain in current status using the plugin name that user has put as primary key. It's difficult for VATZ to extract plugin_id to recognize which plugin must be skipped if the user set enable/disable plugin status.

I think it's good to stick around with the current primary key name for the plugin table. I am going to close this issue unless you have any other comment or further discussions.
Please, let me know.

@xellos00
Copy link
Member

@rootwarp
I close this issue, because seems you don't have any concern with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:svc Anything related to Vatz Service. type:enhancement Any enhancement for feature or anything Vatz Project Name
Projects
None yet
Development

No branches or pull requests

2 participants