Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vatz-proto buffer's Github action enhancement #87

Closed
1 of 6 tasks
xellos00 opened this issue Apr 26, 2022 · 5 comments
Closed
1 of 6 tasks

vatz-proto buffer's Github action enhancement #87

xellos00 opened this issue Apr 26, 2022 · 5 comments
Assignees
Labels
area:ci/cd Anything related to build or update CI/ CD process. type:enhancement Any enhancement for feature or anything Vatz Project Name

Comments

@xellos00
Copy link
Member

xellos00 commented Apr 26, 2022


Checklist

  • New Feature for the Service/Plugin (Vatz)
  • Enhancement (Vatz)
  • others(etcm ie, documentation)

Is your feature request related to a problem? Please describe.
Github action is not fully working as expected.

  • 1. How to compare proto-buff is updated when it has compiled
  • 2. There's no version for now. How to check the version.
  • 3. Skip if there's nothing to commit. (add more conditions)

  • make neat below action

image

  • make clean
    if there's no folder and then it skip for next

Describe the solution you'd like
fails when there's nothing to commit.
image

@xellos00 xellos00 added the Vatz Project Name label Apr 26, 2022
@xellos00 xellos00 self-assigned this Apr 26, 2022
@xellos00 xellos00 changed the title Github action enhancement vatz-proto buffer's Github action enhancement Apr 26, 2022
@xellos00 xellos00 assigned kim201212 and unassigned xellos00 Apr 26, 2022
@xellos00 xellos00 added area:svc Anything related to Vatz Service. area:ci/cd Anything related to build or update CI/ CD process. type:enhancement Any enhancement for feature or anything labels Apr 26, 2022
@xellos00 xellos00 added this to the Sprint 7 ( ~ 2022-04-26) milestone Apr 26, 2022
@xellos00 xellos00 removed the area:svc Anything related to Vatz Service. label May 4, 2022
@kim201212
Copy link
Member

Auto Commit & Push

Test Action in personal repo.

image

image

@xellos00
Copy link
Member Author

xellos00 commented May 12, 2022

@kim201212
Can you create an issue for github action regarding secret_key to vote.

@xellos00
Copy link
Member Author

@kim201212
Can you record whole history of this issue that relate to

let me know when you finish this, so I can close both items.

@kim201212
Copy link
Member

For this CI to work, the CI bot needs to have push permissions.
Since we can't just give it push permissions, we can work around this by giving the CI bot the admin role.
But I think it's dangerous to give the bot the admin role. It's something to consider and decide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:ci/cd Anything related to build or update CI/ CD process. type:enhancement Any enhancement for feature or anything Vatz Project Name
Projects
None yet
Development

No branches or pull requests

2 participants