accept null or undefined for logical type alias #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jraymakers
deleted the
jray/accept-null-or-undef-for-logical-type-alias
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Older versions of TypeScript (than 5.1) require that the type of a
getaccessor be assignable to the type of the correspondingsetaccessor. Because the type ofsetaccessor forDuckDBLogicalType.aliasdid not includeundefined, it triggered a compiler error for these older TS versions. It's trivial to support these older versions by acceptingundefined(ornull) and treating it the same as the empty string, which matches the same behavior as the underlying C API function.See #120