Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let systemd unit file use /etc/sysconfig/munge for munge options #68

Closed
wants to merge 1 commit into from

Conversation

wpoely86
Copy link
Contributor

Fixes #64

This allows you to cleanly specify options to munged. No need to change a unit file.

@dun
Copy link
Owner

dun commented Apr 2, 2019

Thanks for the PR. The main issue I see here is that Red Hat and SUSE use /etc/sysconfig, but Debian and Ubuntu use /etc/default.

Aside from that, the current "sysconfig" file specifies vars for NICE, USER, and GROUP which would have no effect in a systemd configuration. That means I should really have separate template files for sysvinit and systemd. And then the RPM specfile needs to be updated to install the correct template. A lot of this is dependent upon the autotools rework that has yet to be pulled into master, so I'll finish this up once that work is merged.

@kkm000
Copy link

kkm000 commented May 27, 2019

The main issue I see here is that Red Hat and SUSE use /etc/sysconfig, but Debian and Ubuntu use /etc/default.

An (arguably ugly) workaround to unify the two is

EnvironmentFile=-/etc/sysconfig/munge
EnvironmentFile=-/etc/default/munge

The - prefix is to ignore a missing file.

@dun
Copy link
Owner

dun commented May 28, 2019

@kkm000: But that approach doesn't handle the differences between sysvinit and systemd (i.e., where the latter doesn't use NICE, USER, and GROUP). I'm hoping to do something a bit cleaner in the near future.

@kkm000
Copy link

kkm000 commented May 28, 2019

@dun, true, the init scripts would not use them.

@dun dun closed this in 122ea9c Nov 7, 2019
@wpoely86
Copy link
Contributor Author

wpoely86 commented Nov 8, 2019

@dun Any plans for a version update of munge? Now this change and #23 are merged, it would be helpful to have a proper release.

@dun
Copy link
Owner

dun commented Nov 9, 2019

@wpoely86 Yes, 0.5.14 should be out in the next couple of weeks. Just wrapping up a few minor things. Among them, revisiting #23 to probably remove the restriction requiring the --origin arg to match an address assigned to a local network interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

specify daemon options with systemd unit file
3 participants