Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smarter handling of filter duality #17

Closed
gmbecker opened this issue Jun 23, 2017 · 1 comment
Closed

smarter handling of filter duality #17

gmbecker opened this issue Jun 23, 2017 · 1 comment

Comments

@gmbecker
Copy link
Collaborator

Right now it the collector checks whether it knows dplyr has been attached, but the problem here is that it is only checking in the current node, which often isn't where the library call appears.

Need to figure out a better solution for this.

@gmbecker
Copy link
Collaborator Author

There is a fix in place for this which tracks cumulative library loads across nodes when processing a whole script. We're still only checking for presence/absence of attaching dplyr, which isn't quite right (it could be masked later) but it's the best we're going to easily do so I'll wait for that to actually cause a problem before we try to tackle it further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant