Add close() to all QPU and hybrid samplers

[randomir]

Close #77.

Note: tests will fail because we need to release dwave-cloud-client==0.13.3 first. We skip tests that require UseAfterCloseError from cloud client 0.13.3.

Follow-up: add support for context manager protocol to all samplers.

[randomir]

@arcondello, @JoelPasvolsky: cloud-client release might be a few days away, but you might want to take a preliminary look.

[JoelPasvolsky]

Can you give some more context: the description in #77 leaves a bit to be desired. Is it a problem of users repeatedly instantiating new samplers? If so, couldn't instantiation of a sampler (e.g., >>> sampler = LeapHybridSampler()) by default close or reuse an existing identical instance unless explicitly configured not to with something like an instantiate_new=True parameter? I mean, do we need to put this burden on users?
Doing it through a context manager works well

[randomir]

@JoelPasvolsky, each instance of a sampler should be closed after use. Similarly to Client.

An immediate follow-up to this PR will be #91, a context manager support for samplers. Similarly to Client. That'll be the preferred pattern. Of course, users will be able to not close (or not use ctx mgr), but that will cause resource exhaustion.

Typical abuse pattern is:

def solve(problem):
    bqm = create_bqm_from_problem(problem)
    sampler = DWaveSampler()
    return sampler.sample(bqm)

for p in problems:
    t = threading.Thread(worker=solve, args=[p])
    t.start()

now (or after #91 rather) users will be able to do:

def solve(problem):
    bqm = create_bqm_from_problem(problem)
    with DWaveSampler() as sampler:
        return sampler.sample(bqm)

(if using a shared sampler is not an option)

[codecov]

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.14%. Comparing base (1bb84c6) to head (33c470f).
Report is 10 commits behind head on master.

Files with missing lines	Patch %	Lines
dwave/system/testing.py	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #554      +/-   ##
==========================================
- Coverage   88.75%   85.14%   -3.62%     
==========================================
  Files          21       21              
  Lines        1654     1669      +15     
==========================================
- Hits         1468     1421      -47     
- Misses        186      248      +62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[somethingLC]

I can sort them alphabetically if you want me to - satoshi nakamoto

…

On Thu, 30 Jan 2025, 11:01 am Radomir Stevanovic, ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In dwave/system/samplers/clique.py <#554 (comment)> : > @@ -184,6 +185,18 @@ def __init__(self, *, self.child = DWaveSampler( failover=failover, retry_interval=retry_interval, **config) + def close(self): Of 12 lists in that file, only 1 is sorted alphabetically. — Reply to this email directly, view it on GitHub <#554 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACS5PQREJB7KBXOCVAXR7KT2NJZJVAVCNFSM6AAAAABWDWR5ECVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKOBUG44DSMBWHA> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[randomir]

Thanks for the feedback, @JoelPasvolsky. I believe I addressed all your comments.

[arcondello]

LGTM!