Allow arbitrary prefixes for tags #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sideeffffect
force-pushed
the
multi-project-new
branch
3 times, most recently
from
be52464 to
1f752bf
Compare
sideeffffect
changed the title
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
sideeffffect
changed the title
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
# Conflicts: # src/main/scala/sbtdynver/DynVerPlugin.scala # src/test/scala/sbtdynver/RepoStates.scala
dwijnand
force-pushed
the
multi-project-new
branch
from
6c37494 to
9b3c2ad
Compare
Highlights: * Introduce dropPrefix as a replacement for dropV; * Maintain & fast-fail on incoherence against vTagPrefix; * Introduce a private GitTag subclass instead of anonymous ones; * Use pattern quoting for the custom prefix; * Preserve the semantics of all public API; * also, changed 2 test cases to run 3 times to help me fix the impl;
dwijnand
force-pushed
the
multi-project-new
branch
from
9b3c2ad to
e28197a
Compare
dwijnand
approved these changes
Jun 26, 2020
There was a problem hiding this comment.
Thank you, @eliaslevy and @sideeffffect. I finally spent today reviewing and working on the enhancement. I've squash down the history and everything's passing CI (something's up with the webhook notifications?). Anyways, this is ready to merge. Thank you for the contribution.
This was referenced Jun 26, 2020
|
Those are great news @dwijnand 🎉 |
|
Yep, releasing 4.1.0 first thing Monday, if nothing urgent happens. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of #62 by @eliaslevy to bring to
sbt-dynverthe ability to work with arbitrary prefixes for git tags.This effectively allows a particular sbt configuration to focus only on a subset of all the tags in the repository.
This is useful when working with multiple projects in one git repository (monorepo-like), when for example some of the projects might not even use
sbt-dynveror even use sbt or even be written in Scala.The PR is as minimalistic as possible and is backwards compatible, especially with regards to the behavior of
dynverVTagPrefix.Could you @dwijnand please review this? 🙏